Skip to content

Commit 29828b8

Browse files
committed
Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue
Tony Nguyen says: ==================== ice: split ice_virtchnl.c git-blame friendly way Przemek Kitszel says: Split ice_virtchnl.c into two more files (+headers), in a way that git-blame works better. Then move virtchnl files into a new subdir. No logic changes. I have developed (or discovered ;)) how to split a file in a way that both old and new are nice in terms of git-blame There was not much discussion on [RFC], so I would like to propose to go forward with this approach. There are more commits needed to have it nice, so it forms a git-log vs git-blame tradeoff, but (after the brief moment that this is on the top) we spend orders of magnitude more time looking at the blame output (and commit messages linked from that) - so I find it much better to see actual logic changes instead of "move xx to yy" stuff (typical for "squashed/single-commit splits"). Cherry-picks/rebases work the same with this method as with simple "squashed/single-commit" approach (literally all commits squashed into one (to have better git-log, but shitty git-blame output). Rationale for the split itself is, as usual, "file is big and we want to extend it". * '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue: ice: finish virtchnl.c split into rss.c ice: extract virt/rss.c: cleanup - p2 ice: extract virt/rss.c: cleanup - p1 ice: split RSS stuff out of virtchnl.c - copy back ice: split RSS stuff out of virtchnl.c - tmp rename ice: finish virtchnl.c split into queues.c ice: extract virt/queues.c: cleanup - p3 ice: extract virt/queues.c: cleanup - p2 ice: extract virt/queues.c: cleanup - p1 ice: split queue stuff out of virtchnl.c - copy back ice: split queue stuff out of virtchnl.c - tmp rename ice: add virt/ and move ice_virtchnl* files there ==================== Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 15d157c + e0d2795 commit 29828b8

File tree

15 files changed

+1933
-1874
lines changed

15 files changed

+1933
-1874
lines changed

drivers/net/ethernet/intel/ice/Makefile

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,11 @@ ice-y := ice_main.o \
4747
ice_adapter.o
4848
ice-$(CONFIG_PCI_IOV) += \
4949
ice_sriov.o \
50-
ice_virtchnl.o \
51-
ice_virtchnl_allowlist.o \
52-
ice_virtchnl_fdir.o \
50+
virt/allowlist.o \
51+
virt/fdir.o \
52+
virt/queues.o \
53+
virt/virtchnl.o \
54+
virt/rss.o \
5355
ice_vf_mbx.o \
5456
ice_vf_vsi_vlan_ops.o \
5557
ice_vf_lib.o

drivers/net/ethernet/intel/ice/ice_sriov.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include "ice_dcb_lib.h"
1010
#include "ice_flow.h"
1111
#include "ice_eswitch.h"
12-
#include "ice_virtchnl_allowlist.h"
12+
#include "virt/allowlist.h"
1313
#include "ice_flex_pipe.h"
1414
#include "ice_vf_vsi_vlan_ops.h"
1515
#include "ice_vlan.h"

drivers/net/ethernet/intel/ice/ice_sriov.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33

44
#ifndef _ICE_SRIOV_H_
55
#define _ICE_SRIOV_H_
6-
#include "ice_virtchnl_fdir.h"
6+
#include "virt/fdir.h"
77
#include "ice_vf_lib.h"
8-
#include "ice_virtchnl.h"
8+
#include "virt/virtchnl.h"
99

1010
/* Static VF transaction/status register def */
1111
#define VF_DEVICE_STATUS 0xAA

drivers/net/ethernet/intel/ice/ice_vf_lib.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#include "ice.h"
66
#include "ice_lib.h"
77
#include "ice_fltr.h"
8-
#include "ice_virtchnl_allowlist.h"
8+
#include "virt/allowlist.h"
99

1010
/* Public functions which may be accessed by all driver files */
1111

drivers/net/ethernet/intel/ice/ice_vf_lib.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include <linux/avf/virtchnl.h>
1414
#include "ice_type.h"
1515
#include "ice_flow.h"
16-
#include "ice_virtchnl_fdir.h"
16+
#include "virt/fdir.h"
1717
#include "ice_vsi_vlan_ops.h"
1818

1919
#define ICE_MAX_SRIOV_VFS 256

drivers/net/ethernet/intel/ice/ice_virtchnl_allowlist.c renamed to drivers/net/ethernet/intel/ice/virt/allowlist.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// SPDX-License-Identifier: GPL-2.0
22
/* Copyright (C) 2021, Intel Corporation. */
33

4-
#include "ice_virtchnl_allowlist.h"
4+
#include "allowlist.h"
55

66
/* Purpose of this file is to share functionality to allowlist or denylist
77
* opcodes used in PF <-> VF communication. Group of opcodes:
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)