Skip to content

Commit 2cbf977

Browse files
matttbeintel-lab-lkp
authored andcommitted
mptcp: pm: remove unused ret value to set flags
The returned value is not used, it can then be dropped. Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
1 parent 8c4d55a commit 2cbf977

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

net/mptcp/pm_netlink.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1922,13 +1922,11 @@ static void mptcp_pm_nl_fullmesh(struct mptcp_sock *msk,
19221922
spin_unlock_bh(&msk->pm.lock);
19231923
}
19241924

1925-
static int mptcp_nl_set_flags(struct net *net,
1926-
struct mptcp_addr_info *addr,
1927-
u8 bkup, u8 changed)
1925+
static void mptcp_nl_set_flags(struct net *net, struct mptcp_addr_info *addr,
1926+
u8 bkup, u8 changed)
19281927
{
19291928
long s_slot = 0, s_num = 0;
19301929
struct mptcp_sock *msk;
1931-
int ret = -EINVAL;
19321930

19331931
while ((msk = mptcp_token_iter_next(net, &s_slot, &s_num)) != NULL) {
19341932
struct sock *sk = (struct sock *)msk;
@@ -1938,7 +1936,7 @@ static int mptcp_nl_set_flags(struct net *net,
19381936

19391937
lock_sock(sk);
19401938
if (changed & MPTCP_PM_ADDR_FLAG_BACKUP)
1941-
ret = mptcp_pm_nl_mp_prio_send_ack(msk, addr, NULL, bkup);
1939+
mptcp_pm_nl_mp_prio_send_ack(msk, addr, NULL, bkup);
19421940
if (changed & MPTCP_PM_ADDR_FLAG_FULLMESH)
19431941
mptcp_pm_nl_fullmesh(msk, addr);
19441942
release_sock(sk);
@@ -1948,7 +1946,7 @@ static int mptcp_nl_set_flags(struct net *net,
19481946
cond_resched();
19491947
}
19501948

1951-
return ret;
1949+
return;
19521950
}
19531951

19541952
int mptcp_pm_nl_set_flags(struct mptcp_pm_addr_entry *local,

0 commit comments

Comments
 (0)