Skip to content

Commit 351f3d9

Browse files
Shyam Sundar S Kij-intel
authored andcommitted
platform/x86/amd/pmc: Notify user when platform does not support s0ix transition
Some of the AMD platforms do not support modern standby, so when such CPU ID is detected, a warning message will be displayed to the user. Reviewed-by: Mario Limonciello <[email protected]> Co-developed-by: Sanket Goswami <[email protected]> Signed-off-by: Sanket Goswami <[email protected]> Signed-off-by: Shyam Sundar S K <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Ilpo Järvinen <[email protected]> Signed-off-by: Ilpo Järvinen <[email protected]>
1 parent 99923a0 commit 351f3d9

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

drivers/platform/x86/amd/pmc/pmc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -808,6 +808,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
808808
{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_PCO) },
809809
{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_RV) },
810810
{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_SP) },
811+
{ PCI_DEVICE(PCI_VENDOR_ID_AMD, AMD_CPU_ID_SHP) },
811812
{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_1AH_M20H_ROOT) },
812813
{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_1AH_M60H_ROOT) },
813814
{ }
@@ -832,7 +833,7 @@ static int amd_pmc_probe(struct platform_device *pdev)
832833

833834
dev->cpu_id = rdev->device;
834835

835-
if (dev->cpu_id == AMD_CPU_ID_SP) {
836+
if (dev->cpu_id == AMD_CPU_ID_SP || dev->cpu_id == AMD_CPU_ID_SHP) {
836837
dev_warn_once(dev->dev, "S0i3 is not supported on this hardware\n");
837838
err = -ENODEV;
838839
goto err_pci_dev_put;

drivers/platform/x86/amd/pmc/pmc.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ void amd_mp2_stb_deinit(struct amd_pmc_dev *dev);
7979
#define AMD_CPU_ID_CB 0x14D8
8080
#define AMD_CPU_ID_PS 0x14E8
8181
#define AMD_CPU_ID_SP 0x14A4
82+
#define AMD_CPU_ID_SHP 0x153A
8283
#define PCI_DEVICE_ID_AMD_1AH_M20H_ROOT 0x1507
8384
#define PCI_DEVICE_ID_AMD_1AH_M60H_ROOT 0x1122
8485
#define PCI_DEVICE_ID_AMD_MP2_STB 0x172c

0 commit comments

Comments
 (0)