Skip to content

Commit 45ab516

Browse files
Charles HanJiri Kosina
authored andcommitted
HID: winwing: Add NULL check in winwing_init_led()
devm_kasprintf() can return a NULL pointer on failure,but this returned value in winwing_init_led() is not checked. Add NULL check in winwing_init_led(), to handle kernel NULL pointer dereference error. Fixes: 266c990 ("HID: Add WinWing Orion2 throttle support") Signed-off-by: Charles Han <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 05c4ede commit 45ab516

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/hid/hid-winwing.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ static int winwing_init_led(struct hid_device *hdev,
106106
"%s::%s",
107107
dev_name(&input->dev),
108108
info->led_name);
109+
if (!led->cdev.name)
110+
return -ENOMEM;
109111

110112
ret = devm_led_classdev_register(&hdev->dev, &led->cdev);
111113
if (ret)

0 commit comments

Comments
 (0)