Skip to content

Commit 4adbab9

Browse files
Geliang Tangmatttbe
authored andcommitted
bpf: Export mptcp packet scheduler helpers
This patch adds a new struct btf_kfunc_id_set for MPTCP scheduler. Add mptcp_subflow_set_scheduled() and mptcp_sched_data_set_contexts() helpers into this id_set, and register it in bpf_mptcp_kfunc_init() to make sure these helpers can be accessed from the BPF context. Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Geliang Tang <[email protected]>
1 parent 8024409 commit 4adbab9

File tree

3 files changed

+27
-2
lines changed

3 files changed

+27
-2
lines changed

net/mptcp/bpf.c

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,11 @@ bpf_mptcp_subflow_ctx_by_pos(const struct mptcp_sched_data *data, unsigned int p
305305
return data->contexts[pos];
306306
}
307307

308+
__bpf_kfunc static bool bpf_mptcp_subflow_queues_empty(struct sock *sk)
309+
{
310+
return tcp_rtx_queue_empty(sk);
311+
}
312+
308313
__bpf_kfunc_end_defs();
309314

310315
BTF_KFUNCS_START(bpf_mptcp_common_kfunc_ids)
@@ -321,13 +326,31 @@ static const struct btf_kfunc_id_set bpf_mptcp_common_kfunc_set = {
321326
.set = &bpf_mptcp_common_kfunc_ids,
322327
};
323328

329+
BTF_KFUNCS_START(bpf_mptcp_sched_kfunc_ids)
330+
BTF_ID_FLAGS(func, mptcp_subflow_set_scheduled)
331+
BTF_ID_FLAGS(func, bpf_mptcp_subflow_ctx_by_pos)
332+
BTF_ID_FLAGS(func, mptcp_subflow_active)
333+
BTF_ID_FLAGS(func, mptcp_set_timeout)
334+
BTF_ID_FLAGS(func, mptcp_wnd_end)
335+
BTF_ID_FLAGS(func, tcp_stream_memory_free)
336+
BTF_ID_FLAGS(func, bpf_mptcp_subflow_queues_empty)
337+
BTF_ID_FLAGS(func, mptcp_pm_subflow_chk_stale, KF_SLEEPABLE)
338+
BTF_KFUNCS_END(bpf_mptcp_sched_kfunc_ids)
339+
340+
static const struct btf_kfunc_id_set bpf_mptcp_sched_kfunc_set = {
341+
.owner = THIS_MODULE,
342+
.set = &bpf_mptcp_sched_kfunc_ids,
343+
};
344+
324345
static int __init bpf_mptcp_kfunc_init(void)
325346
{
326347
int ret;
327348

328349
ret = register_btf_fmodret_id_set(&bpf_mptcp_fmodret_set);
329350
ret = ret ?: register_btf_kfunc_id_set(BPF_PROG_TYPE_CGROUP_SOCKOPT,
330351
&bpf_mptcp_common_kfunc_set);
352+
ret = ret ?: register_btf_kfunc_id_set(BPF_PROG_TYPE_STRUCT_OPS,
353+
&bpf_mptcp_sched_kfunc_set);
331354
#ifdef CONFIG_BPF_JIT
332355
ret = ret ?: register_bpf_struct_ops(&bpf_mptcp_sched_ops, mptcp_sched_ops);
333356
#endif

net/mptcp/protocol.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ DEFINE_PER_CPU(struct mptcp_delegated_action, mptcp_delegated_actions);
5050
static struct net_device *mptcp_napi_dev;
5151

5252
/* Returns end sequence number of the receiver's advertised window */
53-
static u64 mptcp_wnd_end(const struct mptcp_sock *msk)
53+
u64 mptcp_wnd_end(const struct mptcp_sock *msk)
5454
{
5555
return READ_ONCE(msk->wnd_end);
5656
}
@@ -425,7 +425,7 @@ static long mptcp_timeout_from_subflow(const struct mptcp_subflow_context *subfl
425425
inet_csk(ssk)->icsk_timeout - jiffies : 0;
426426
}
427427

428-
static void mptcp_set_timeout(struct sock *sk)
428+
void mptcp_set_timeout(struct sock *sk)
429429
{
430430
struct mptcp_subflow_context *subflow;
431431
long tout = 0;

net/mptcp/protocol.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -716,6 +716,8 @@ void __mptcp_subflow_send_ack(struct sock *ssk);
716716
void mptcp_subflow_reset(struct sock *ssk);
717717
void mptcp_subflow_queue_clean(struct sock *sk, struct sock *ssk);
718718
void mptcp_sock_graft(struct sock *sk, struct socket *parent);
719+
u64 mptcp_wnd_end(const struct mptcp_sock *msk);
720+
void mptcp_set_timeout(struct sock *sk);
719721
struct mptcp_subflow_context *
720722
bpf_mptcp_subflow_ctx_by_pos(const struct mptcp_sched_data *data, unsigned int pos);
721723
struct sock *__mptcp_nmpc_sk(struct mptcp_sock *msk);

0 commit comments

Comments
 (0)