Skip to content

Commit 4b1ca12

Browse files
MaxKellermannbrauner
authored andcommitted
fs/netfs: remove unused flag NETFS_RREQ_BLOCKED
NETFS_RREQ_BLOCKED was added by commit 016dc85 ("netfs: Implement unbuffered/DIO read support") but has never been used either. Without NETFS_RREQ_BLOCKED, NETFS_RREQ_NONBLOCK makes no sense, and thus can be removed as well. Signed-off-by: Max Kellermann <[email protected]> Signed-off-by: David Howells <[email protected]> Link: https://lore.kernel.org/[email protected] cc: Paulo Alcantara <[email protected]> cc: [email protected] cc: [email protected] Signed-off-by: Christian Brauner <[email protected]>
1 parent 67b9167 commit 4b1ca12

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

fs/netfs/direct_read.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,6 @@ static int netfs_dispatch_unbuffered_reads(struct netfs_io_request *rreq)
106106
netfs_wait_for_pause(rreq);
107107
if (test_bit(NETFS_RREQ_FAILED, &rreq->flags))
108108
break;
109-
if (test_bit(NETFS_RREQ_BLOCKED, &rreq->flags) &&
110-
test_bit(NETFS_RREQ_NONBLOCK, &rreq->flags))
111-
break;
112109
cond_resched();
113110
} while (size > 0);
114111

fs/netfs/objects.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ struct netfs_io_request *netfs_alloc_request(struct address_space *mapping,
6464
}
6565

6666
__set_bit(NETFS_RREQ_IN_PROGRESS, &rreq->flags);
67-
if (file && file->f_flags & O_NONBLOCK)
68-
__set_bit(NETFS_RREQ_NONBLOCK, &rreq->flags);
6967
if (rreq->netfs_ops->init_request) {
7068
ret = rreq->netfs_ops->init_request(rreq, file);
7169
if (ret < 0) {

include/linux/netfs.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,6 @@ struct netfs_io_request {
270270
#define NETFS_RREQ_IN_PROGRESS 5 /* Unlocked when the request completes */
271271
#define NETFS_RREQ_FOLIO_COPY_TO_CACHE 6 /* Copy current folio to cache from read */
272272
#define NETFS_RREQ_UPLOAD_TO_SERVER 8 /* Need to write to the server */
273-
#define NETFS_RREQ_NONBLOCK 9 /* Don't block if possible (O_NONBLOCK) */
274-
#define NETFS_RREQ_BLOCKED 10 /* We blocked */
275273
#define NETFS_RREQ_PAUSE 11 /* Pause subrequest generation */
276274
#define NETFS_RREQ_USE_IO_ITER 12 /* Use ->io_iter rather than ->i_pages */
277275
#define NETFS_RREQ_ALL_QUEUED 13 /* All subreqs are now queued */

0 commit comments

Comments
 (0)