Skip to content

Commit 4c12245

Browse files
cxgb4: Avoid removal of uninserted tid
During ARP failure, tid is not inserted but _c4iw_free_ep() attempts to remove tid which results in error. This patch fixes the issue by avoiding removal of uninserted tid. Fixes: 59437d7 ("cxgb4/chtls: fix ULD connection failures due to wrong TID base") Signed-off-by: Anumula Murali Mohan Reddy <[email protected]> Signed-off-by: Potnuri Bharat Teja <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 3085d4b commit 4c12245

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1799,7 +1799,10 @@ void cxgb4_remove_tid(struct tid_info *t, unsigned int chan, unsigned int tid,
17991799
struct adapter *adap = container_of(t, struct adapter, tids);
18001800
struct sk_buff *skb;
18011801

1802-
WARN_ON(tid_out_of_range(&adap->tids, tid));
1802+
if (tid_out_of_range(&adap->tids, tid)) {
1803+
dev_err(adap->pdev_dev, "tid %d out of range\n", tid);
1804+
return;
1805+
}
18031806

18041807
if (t->tid_tab[tid - adap->tids.tid_base]) {
18051808
t->tid_tab[tid - adap->tids.tid_base] = NULL;

0 commit comments

Comments
 (0)