Skip to content

Commit 5f3d319

Browse files
orospanguy11
authored andcommitted
iavf: schedule a request immediately after add/delete vlan
When the iavf driver wants to reconfigure the VLAN filters (iavf_add_vlan, iavf_del_vlan), it sets a flag in aq_required: adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER; or: adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER; This is later processed by the watchdog_task, but it runs periodically every 2 seconds, so it can be a long time before it processes the request. In the worst case, the interface is unable to receive traffic for more than 2 seconds for no objective reason. Fixes: 5eae00c ("i40evf: main driver core") Signed-off-by: Petr Oros <[email protected]> Co-developed-by: Michal Schmidt <[email protected]> Signed-off-by: Michal Schmidt <[email protected]> Co-developed-by: Ivan Vecera <[email protected]> Signed-off-by: Ivan Vecera <[email protected]> Reviewed-by: Ahmed Zaki <[email protected]> Reviewed-by: Simon Horman <[email protected]> Tested-by: Rafal Romanowski <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent ed4cad3 commit 5f3d319

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/intel/iavf/iavf_main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter,
821821
list_add_tail(&f->list, &adapter->vlan_filter_list);
822822
f->state = IAVF_VLAN_ADD;
823823
adapter->num_vlan_filters++;
824-
adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
824+
iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER);
825825
}
826826

827827
clearout:
@@ -843,7 +843,7 @@ static void iavf_del_vlan(struct iavf_adapter *adapter, struct iavf_vlan vlan)
843843
f = iavf_find_vlan(adapter, vlan);
844844
if (f) {
845845
f->state = IAVF_VLAN_REMOVE;
846-
adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
846+
iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DEL_VLAN_FILTER);
847847
}
848848

849849
spin_unlock_bh(&adapter->mac_vlan_list_lock);

0 commit comments

Comments
 (0)