Skip to content

Commit 66477c7

Browse files
Peter ZijlstraIngo Molnar
authored andcommitted
perf/core: Fix perf_mmap() failure path
When f_ops->mmap() returns failure, m_ops->close() is *not* called. Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Acked-by: Lorenzo Stoakes <[email protected]> Reviewed-by: Ravi Bangoria <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 4eabf53 commit 66477c7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/events/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6903,7 +6903,7 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma)
69036903
if (!ret)
69046904
ret = map_range(rb, vma);
69056905

6906-
if (event->pmu->event_mapped)
6906+
if (!ret && event->pmu->event_mapped)
69076907
event->pmu->event_mapped(event, vma->vm_mm);
69086908

69096909
return ret;

0 commit comments

Comments
 (0)