Skip to content

Commit 68e5afd

Browse files
arndbWim Van Sebroeck
authored andcommitted
watchdog: lenovo_se10_wdt: add HAS_IOPORT dependency
Once the inb()/outb() helpers become conditional, the newly added driver fails to link on targets without CONFIG_HAS_IOPORT: In file included from arch/arm64/include/asm/io.h:299, from include/linux/io.h:14, from drivers/watchdog/lenovo_se10_wdt.c:8: drivers/watchdog/lenovo_se10_wdt.c: In function 'set_bram': include/asm-generic/io.h:596:15: error: call to '_outb' declared with attribute error: outb() requires CONFIG_HAS_IOPORT 596 | #define _outb _outb include/asm-generic/io.h:655:14: note: in expansion of macro '_outb' 655 | #define outb _outb | ^~~~~ drivers/watchdog/lenovo_se10_wdt.c:67:9: note: in expansion of macro 'outb' 67 | outb(offset, bram_base); | ^~~~ Add the same dependency we added to the other such drivers. Fixes: 1f6602c ("watchdog: lenovo_se10_wdt: Watchdog driver for Lenovo SE10 platform") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by Mark Pearson <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
1 parent c3f38fa commit 68e5afd

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/watchdog/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ config GPIO_WATCHDOG_ARCH_INITCALL
257257
config LENOVO_SE10_WDT
258258
tristate "Lenovo SE10 Watchdog"
259259
depends on (X86 && DMI) || COMPILE_TEST
260+
depends on HAS_IOPORT
260261
select WATCHDOG_CORE
261262
help
262263
If you say yes here you get support for the watchdog

0 commit comments

Comments
 (0)