Skip to content

Commit 863ff54

Browse files
liuhangbindavem330
authored andcommitted
selftests: forwarding: skip if kernel not support setting bridge fdb learning limit
If the testing kernel doesn't support setting fdb_max_learned or show fdb_n_learned, just skip it. Or we will get errors like ./bridge_fdb_learning_limit.sh: line 218: [: null: integer expression expected ./bridge_fdb_learning_limit.sh: line 225: [: null: integer expression expected Fixes: 6f84090 ("selftests: forwarding: bridge_fdb_learning_limit: Add a new selftest") Signed-off-by: Hangbin Liu <[email protected]> Acked-by: Nikolay Aleksandrov <[email protected]> Reviewed-by: Johannes Nixdorf <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent fa96c6b commit 863ff54

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

tools/testing/selftests/net/forwarding/bridge_fdb_learning_limit.sh

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,22 @@ fdb_del()
178178
check_err $? "Failed to remove a FDB entry of type ${type}"
179179
}
180180

181+
check_fdb_n_learned_support()
182+
{
183+
if ! ip link help bridge 2>&1 | grep -q "fdb_max_learned"; then
184+
echo "SKIP: iproute2 too old, missing bridge max learned support"
185+
exit $ksft_skip
186+
fi
187+
188+
ip link add dev br0 type bridge
189+
local learned=$(fdb_get_n_learned)
190+
ip link del dev br0
191+
if [ "$learned" == "null" ]; then
192+
echo "SKIP: kernel too old; bridge fdb_n_learned feature not supported."
193+
exit $ksft_skip
194+
fi
195+
}
196+
181197
check_accounting_one_type()
182198
{
183199
local type=$1 is_counted=$2 overrides_learned=$3
@@ -274,6 +290,8 @@ check_limit()
274290
done
275291
}
276292

293+
check_fdb_n_learned_support
294+
277295
trap cleanup EXIT
278296

279297
setup_prepare

0 commit comments

Comments
 (0)