Skip to content

Commit 893e75d

Browse files
Geliang Tangintel-lab-lkp
authored andcommitted
Squash to "selftests/bpf: Add bpf scheduler test"
A cleanup, move netns_new() out of sched_init(). Signed-off-by: Geliang Tang <[email protected]>
1 parent 4a30883 commit 893e75d

File tree

1 file changed

+10
-12
lines changed
  • tools/testing/selftests/bpf/prog_tests

1 file changed

+10
-12
lines changed

tools/testing/selftests/bpf/prog_tests/mptcp.c

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -562,23 +562,16 @@ static void test_iters_subflow(void)
562562
close(cgroup_fd);
563563
}
564564

565-
static struct netns_obj *sched_init(char *flags, char *sched)
565+
static int sched_init(char *flags, char *sched)
566566
{
567-
struct netns_obj *netns;
568-
569-
netns = netns_new(NS_TEST, true);
570-
if (!ASSERT_OK_PTR(netns, "netns_new"))
571-
return NULL;
572-
573-
if (endpoint_init("subflow", 2) < 0)
567+
if (endpoint_init(flags, 2) < 0)
574568
goto fail;
575569

576570
SYS(fail, "ip netns exec %s sysctl -qw net.mptcp.scheduler=%s", NS_TEST, sched);
577571

578-
return netns;
572+
return 0;
579573
fail:
580-
netns_free(netns);
581-
return NULL;
574+
return -1;
582575
}
583576

584577
static int ss_search(char *src, char *dst, char *port, char *keyword)
@@ -636,11 +629,16 @@ static void send_data_and_verify(char *sched, bool addr1, bool addr2)
636629
static void test_default(void)
637630
{
638631
struct netns_obj *netns;
632+
int err;
639633

640-
netns = sched_init("subflow", "default");
634+
netns = netns_new(NS_TEST, true);
641635
if (!netns)
642636
goto fail;
643637

638+
err = sched_init("subflow", "default");
639+
if (!ASSERT_OK(err, "sched_init"))
640+
goto fail;
641+
644642
send_data_and_verify("default", WITH_DATA, WITH_DATA);
645643

646644
fail:

0 commit comments

Comments
 (0)