Skip to content

Commit 924d660

Browse files
arndbChun-Kuang Hu
authored andcommitted
drm/mediatek: stop selecting foreign drivers
The PHY portion of the mediatek hdmi driver was originally part of the driver it self and later split out into drivers/phy, which a 'select' to keep the prior behavior. However, this leads to build failures when the PHY driver cannot be built: WARNING: unmet direct dependencies detected for PHY_MTK_HDMI Depends on [n]: (ARCH_MEDIATEK || COMPILE_TEST [=y]) && COMMON_CLK [=y] && OF [=y] && REGULATOR [=n] Selected by [m]: - DRM_MEDIATEK_HDMI [=m] && HAS_IOMEM [=y] && DRM [=m] && DRM_MEDIATEK [=m] ERROR: modpost: "devm_regulator_register" [drivers/phy/mediatek/phy-mtk-hdmi-drv.ko] undefined! ERROR: modpost: "rdev_get_drvdata" [drivers/phy/mediatek/phy-mtk-hdmi-drv.ko] undefined! The best option here is to just not select the phy driver and leave that up to the defconfig. Do the same for the other PHY and memory drivers selected here as well for consistency. Fixes: a481bf2 ("drm/mediatek: Separate mtk_hdmi_phy to an independent module") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: AngeloGioacchino Del Regno <[email protected]> Reviewed-by: CK Hu <[email protected]> Link: https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/ Signed-off-by: Chun-Kuang Hu <[email protected]>
1 parent 5c9d7e7 commit 924d660

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/gpu/drm/mediatek/Kconfig

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ config DRM_MEDIATEK
1414
select DRM_BRIDGE_CONNECTOR
1515
select DRM_MIPI_DSI
1616
select DRM_PANEL
17-
select MEMORY
18-
select MTK_SMI
19-
select PHY_MTK_MIPI_DSI
2017
select VIDEOMODE_HELPERS
2118
help
2219
Choose this option if you have a Mediatek SoCs.
@@ -27,7 +24,6 @@ config DRM_MEDIATEK
2724
config DRM_MEDIATEK_DP
2825
tristate "DRM DPTX Support for MediaTek SoCs"
2926
depends on DRM_MEDIATEK
30-
select PHY_MTK_DP
3127
select DRM_DISPLAY_HELPER
3228
select DRM_DISPLAY_DP_HELPER
3329
select DRM_DISPLAY_DP_AUX_BUS
@@ -38,6 +34,5 @@ config DRM_MEDIATEK_HDMI
3834
tristate "DRM HDMI Support for Mediatek SoCs"
3935
depends on DRM_MEDIATEK
4036
select SND_SOC_HDMI_CODEC if SND_SOC
41-
select PHY_MTK_HDMI
4237
help
4338
DRM/KMS HDMI driver for Mediatek SoCs

0 commit comments

Comments
 (0)