Skip to content

Commit 9fa560f

Browse files
committed
drm/i915: Simplify vlv_wait_port_ready() arguments
Currently vlv_wait_port_ready() takes the display+dig_port, but all it really needs is the encoder. The display can be dug out from therein. Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Jani Nikula <[email protected]>
1 parent 2be189c commit 9fa560f

File tree

4 files changed

+10
-14
lines changed

4 files changed

+10
-14
lines changed

drivers/gpu/drm/i915/display/g4x_dp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,7 @@ static void intel_enable_dp(struct intel_atomic_state *state,
701701
if (display->platform.cherryview)
702702
lane_mask = intel_dp_unused_lane_mask(pipe_config->lane_count);
703703

704-
vlv_wait_port_ready(display, dp_to_dig_port(intel_dp), lane_mask);
704+
vlv_wait_port_ready(encoder, lane_mask);
705705
}
706706

707707
intel_dp_set_power(intel_dp, DP_SET_POWER_D0);

drivers/gpu/drm/i915/display/g4x_hdmi.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,6 @@ static void vlv_hdmi_pre_enable(struct intel_atomic_state *state,
479479
const struct intel_crtc_state *pipe_config,
480480
const struct drm_connector_state *conn_state)
481481
{
482-
struct intel_display *display = to_intel_display(encoder);
483482
struct intel_digital_port *dig_port = enc_to_dig_port(encoder);
484483

485484
vlv_phy_pre_encoder_enable(encoder, pipe_config);
@@ -495,7 +494,7 @@ static void vlv_hdmi_pre_enable(struct intel_atomic_state *state,
495494

496495
g4x_hdmi_enable_port(encoder, pipe_config);
497496

498-
vlv_wait_port_ready(display, dig_port, 0x0);
497+
vlv_wait_port_ready(encoder, 0x0);
499498
}
500499

501500
static void vlv_hdmi_pre_pll_enable(struct intel_atomic_state *state,
@@ -556,7 +555,6 @@ static void chv_hdmi_pre_enable(struct intel_atomic_state *state,
556555
const struct intel_crtc_state *pipe_config,
557556
const struct drm_connector_state *conn_state)
558557
{
559-
struct intel_display *display = to_intel_display(encoder);
560558
struct intel_digital_port *dig_port = enc_to_dig_port(encoder);
561559

562560
chv_phy_pre_encoder_enable(encoder, pipe_config);
@@ -571,7 +569,7 @@ static void chv_hdmi_pre_enable(struct intel_atomic_state *state,
571569

572570
g4x_hdmi_enable_port(encoder, pipe_config);
573571

574-
vlv_wait_port_ready(display, dig_port, 0x0);
572+
vlv_wait_port_ready(encoder, 0x0);
575573

576574
/* Second common lane will stay alive on its own now */
577575
chv_phy_release_cl2_override(encoder);

drivers/gpu/drm/i915/display/intel_dpio_phy.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1157,16 +1157,16 @@ void vlv_phy_reset_lanes(struct intel_encoder *encoder,
11571157
vlv_dpio_put(dev_priv);
11581158
}
11591159

1160-
void vlv_wait_port_ready(struct intel_display *display,
1161-
struct intel_digital_port *dig_port,
1160+
void vlv_wait_port_ready(struct intel_encoder *encoder,
11621161
unsigned int expected_mask)
11631162
{
1163+
struct intel_display *display = to_intel_display(encoder);
11641164
u32 port_mask;
11651165
i915_reg_t dpll_reg;
11661166

1167-
switch (dig_port->base.port) {
1167+
switch (encoder->port) {
11681168
default:
1169-
MISSING_CASE(dig_port->base.port);
1169+
MISSING_CASE(encoder->port);
11701170
fallthrough;
11711171
case PORT_B:
11721172
port_mask = DPLL_PORTB_READY_MASK;
@@ -1186,7 +1186,7 @@ void vlv_wait_port_ready(struct intel_display *display,
11861186
if (intel_de_wait(display, dpll_reg, port_mask, expected_mask, 1000))
11871187
drm_WARN(display->drm, 1,
11881188
"timed out waiting for [ENCODER:%d:%s] port ready: got 0x%x, expected 0x%x\n",
1189-
dig_port->base.base.base.id, dig_port->base.base.name,
1189+
encoder->base.base.id, encoder->base.name,
11901190
intel_de_read(display, dpll_reg) & port_mask,
11911191
expected_mask);
11921192
}

drivers/gpu/drm/i915/display/intel_dpio_phy.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ void vlv_phy_pre_encoder_enable(struct intel_encoder *encoder,
7272
const struct intel_crtc_state *crtc_state);
7373
void vlv_phy_reset_lanes(struct intel_encoder *encoder,
7474
const struct intel_crtc_state *old_crtc_state);
75-
void vlv_wait_port_ready(struct intel_display *display,
76-
struct intel_digital_port *dig_port,
75+
void vlv_wait_port_ready(struct intel_encoder *encoder,
7776
unsigned int expected_mask);
7877
#else
7978
static inline void bxt_port_to_phy_channel(struct intel_display *display, enum port port,
@@ -173,8 +172,7 @@ static inline void vlv_phy_reset_lanes(struct intel_encoder *encoder,
173172
const struct intel_crtc_state *old_crtc_state)
174173
{
175174
}
176-
static inline void vlv_wait_port_ready(struct intel_display *display,
177-
struct intel_digital_port *dig_port,
175+
static inline void vlv_wait_port_ready(struct intel_encoder *encoder,
178176
unsigned int expected_mask)
179177
{
180178
}

0 commit comments

Comments
 (0)