Skip to content

Commit a20b863

Browse files
isilenceaxboe
authored andcommitted
io_uring/net: open code io_sendmsg_copy_hdr()
io_sendmsg_setup() is trivial and io_sendmsg_copy_hdr() doesn't add any good abstraction, open code one into another. Signed-off-by: Pavel Begunkov <[email protected]> Link: https://lore.kernel.org/r/565318ce585665e88053663eeee5178d2c15692f.1743202294.git.asml.silence@gmail.com Signed-off-by: Jens Axboe <[email protected]>
1 parent 00cfc05 commit a20b863

File tree

1 file changed

+10
-20
lines changed

1 file changed

+10
-20
lines changed

io_uring/net.c

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -325,25 +325,6 @@ static int io_msg_copy_hdr(struct io_kiocb *req, struct io_async_msghdr *iomsg,
325325
return 0;
326326
}
327327

328-
static int io_sendmsg_copy_hdr(struct io_kiocb *req,
329-
struct io_async_msghdr *iomsg)
330-
{
331-
struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg);
332-
struct user_msghdr msg;
333-
int ret;
334-
335-
ret = io_msg_copy_hdr(req, iomsg, &msg, ITER_SOURCE, NULL);
336-
if (unlikely(ret))
337-
return ret;
338-
339-
if (!(req->flags & REQ_F_BUFFER_SELECT))
340-
ret = io_net_import_vec(req, iomsg, msg.msg_iov, msg.msg_iovlen,
341-
ITER_SOURCE);
342-
/* save msg_control as sys_sendmsg() overwrites it */
343-
sr->msg_control = iomsg->msg.msg_control_user;
344-
return ret;
345-
}
346-
347328
void io_sendmsg_recvmsg_cleanup(struct io_kiocb *req)
348329
{
349330
struct io_async_msghdr *io = req->async_data;
@@ -392,10 +373,19 @@ static int io_sendmsg_setup(struct io_kiocb *req, const struct io_uring_sqe *sqe
392373
{
393374
struct io_sr_msg *sr = io_kiocb_to_cmd(req, struct io_sr_msg);
394375
struct io_async_msghdr *kmsg = req->async_data;
376+
struct user_msghdr msg;
377+
int ret;
395378

396379
sr->umsg = u64_to_user_ptr(READ_ONCE(sqe->addr));
380+
ret = io_msg_copy_hdr(req, kmsg, &msg, ITER_SOURCE, NULL);
381+
if (unlikely(ret))
382+
return ret;
383+
/* save msg_control as sys_sendmsg() overwrites it */
384+
sr->msg_control = kmsg->msg.msg_control_user;
397385

398-
return io_sendmsg_copy_hdr(req, kmsg);
386+
if (req->flags & REQ_F_BUFFER_SELECT)
387+
return 0;
388+
return io_net_import_vec(req, kmsg, msg.msg_iov, msg.msg_iovlen, ITER_SOURCE);
399389
}
400390

401391
static int io_sendmsg_zc_setup(struct io_kiocb *req, const struct io_uring_sqe *sqe)

0 commit comments

Comments
 (0)