Skip to content

Commit a5b792b

Browse files
matttbeintel-lab-lkp
authored andcommitted
mptcp: pm: export mptcp_remote_address
In a following commit, the 'remote_address' helper will need to be used from different files. It is then exported, and prefixed with 'mptcp_', similar to 'mptcp_local_address'. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
1 parent a94e916 commit a5b792b

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

net/mptcp/pm_netlink.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ void mptcp_local_address(const struct sock_common *skc, struct mptcp_addr_info *
9494
#endif
9595
}
9696

97-
static void remote_address(const struct sock_common *skc,
98-
struct mptcp_addr_info *addr)
97+
void mptcp_remote_address(const struct sock_common *skc,
98+
struct mptcp_addr_info *addr)
9999
{
100100
addr->family = skc->skc_family;
101101
addr->port = skc->skc_dport;
@@ -138,7 +138,7 @@ static bool lookup_subflow_by_daddr(const struct list_head *list,
138138
(TCPF_ESTABLISHED | TCPF_SYN_SENT | TCPF_SYN_RECV)))
139139
continue;
140140

141-
remote_address((struct sock_common *)ssk, &cur);
141+
mptcp_remote_address((struct sock_common *)ssk, &cur);
142142
if (mptcp_addresses_equal(&cur, daddr, daddr->port))
143143
return true;
144144
}
@@ -428,7 +428,7 @@ static unsigned int fill_remote_addresses_vec(struct mptcp_sock *msk,
428428
int i = 0;
429429

430430
subflows_max = mptcp_pm_get_subflows_max(msk);
431-
remote_address((struct sock_common *)sk, &remote);
431+
mptcp_remote_address((struct sock_common *)sk, &remote);
432432

433433
/* Non-fullmesh endpoint, fill in the single entry
434434
* corresponding to the primary MPC subflow remote address
@@ -455,7 +455,7 @@ static unsigned int fill_remote_addresses_vec(struct mptcp_sock *msk,
455455

456456
mptcp_for_each_subflow(msk, subflow) {
457457
ssk = mptcp_subflow_tcp_sock(subflow);
458-
remote_address((struct sock_common *)ssk, &addrs[i]);
458+
mptcp_remote_address((struct sock_common *)ssk, &addrs[i]);
459459
addrs[i].id = READ_ONCE(subflow->remote_id);
460460
if (deny_id0 && !addrs[i].id)
461461
continue;
@@ -777,7 +777,7 @@ bool mptcp_pm_is_init_remote_addr(struct mptcp_sock *msk,
777777
{
778778
struct mptcp_addr_info mpc_remote;
779779

780-
remote_address((struct sock_common *)msk, &mpc_remote);
780+
mptcp_remote_address((struct sock_common *)msk, &mpc_remote);
781781
return mptcp_addresses_equal(&mpc_remote, remote, remote->port);
782782
}
783783

@@ -826,7 +826,7 @@ int mptcp_pm_mp_prio_send_ack(struct mptcp_sock *msk,
826826
continue;
827827

828828
if (rem && rem->family != AF_UNSPEC) {
829-
remote_address((struct sock_common *)ssk, &remote);
829+
mptcp_remote_address((struct sock_common *)ssk, &remote);
830830
if (!mptcp_addresses_equal(&remote, rem, rem->port))
831831
continue;
832832
}

net/mptcp/protocol.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,10 @@ void mptcp_set_state(struct sock *sk, int state);
729729

730730
bool mptcp_addresses_equal(const struct mptcp_addr_info *a,
731731
const struct mptcp_addr_info *b, bool use_port);
732-
void mptcp_local_address(const struct sock_common *skc, struct mptcp_addr_info *addr);
732+
void mptcp_local_address(const struct sock_common *skc,
733+
struct mptcp_addr_info *addr);
734+
void mptcp_remote_address(const struct sock_common *skc,
735+
struct mptcp_addr_info *addr);
733736

734737
/* called with sk socket lock held */
735738
int __mptcp_subflow_connect(struct sock *sk, const struct mptcp_pm_local *local,

0 commit comments

Comments
 (0)