Skip to content

Commit a5d8922

Browse files
XinIZengherbertx
authored andcommitted
crypto: qat - fix linking errors when PCI_IOV is disabled
When CONFIG_PCI_IOV=n, the build of the QAT vfio pci variant driver fails reporting the following linking errors: ERROR: modpost: "qat_vfmig_open" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_resume" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_save_state" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_suspend" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_load_state" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_reset" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_save_setup" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_destroy" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_close" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! ERROR: modpost: "qat_vfmig_cleanup" [drivers/vfio/pci/qat/qat_vfio_pci.ko] undefined! WARNING: modpost: suppressed 1 unresolved symbol warnings because there were too many) Make live migration helpers provided by QAT PF driver always available even if CONFIG_PCI_IOV is not selected. This does not cause any side effect. Reported-by: Arnd Bergmann <[email protected]> Closes: https://lore.kernel.org/lkml/[email protected]/T/ Fixes: bb20881 ("vfio/qat: Add vfio_pci driver for Intel QAT SR-IOV VF devices") Signed-off-by: Xin Zeng <[email protected]> Reviewed-by: Giovanni Cabiddu <[email protected]> Reviewed-by: Kevin Tian <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent 67ec8cd commit a5d8922

File tree

1 file changed

+3
-2
lines changed
  • drivers/crypto/intel/qat/qat_common

1 file changed

+3
-2
lines changed

drivers/crypto/intel/qat/qat_common/Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ intel_qat-objs := adf_cfg.o \
3939
adf_sysfs_rl.o \
4040
qat_uclo.o \
4141
qat_hal.o \
42-
qat_bl.o
42+
qat_bl.o \
43+
qat_mig_dev.o
4344

4445
intel_qat-$(CONFIG_DEBUG_FS) += adf_transport_debug.o \
4546
adf_fw_counters.o \
@@ -56,6 +57,6 @@ intel_qat-$(CONFIG_DEBUG_FS) += adf_transport_debug.o \
5657
intel_qat-$(CONFIG_PCI_IOV) += adf_sriov.o adf_vf_isr.o adf_pfvf_utils.o \
5758
adf_pfvf_pf_msg.o adf_pfvf_pf_proto.o \
5859
adf_pfvf_vf_msg.o adf_pfvf_vf_proto.o \
59-
adf_gen2_pfvf.o adf_gen4_pfvf.o qat_mig_dev.o
60+
adf_gen2_pfvf.o adf_gen4_pfvf.o
6061

6162
intel_qat-$(CONFIG_CRYPTO_DEV_QAT_ERROR_INJECTION) += adf_heartbeat_inject.o

0 commit comments

Comments
 (0)