Skip to content

Commit a8c9a45

Browse files
Nikita Zhandarovichbroonie
authored andcommitted
ASoC: fsl_micfil: Enable default case in micfil_set_quality()
If 'micfil->quality' received from micfil_quality_set() somehow ends up with an unpredictable value, switch() operator will fail to initialize local variable qsel before regmap_update_bits() tries to utilize it. While it is unlikely, play it safe and enable a default case that returns -EINVAL error. Found by Linux Verification Center (linuxtesting.org) with static analysis tool SVACE. Fixes: bea1d61 ("ASoC: fsl_micfil: rework quality setting") Cc: [email protected] Signed-off-by: Nikita Zhandarovich <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 2014c95 commit a8c9a45

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

sound/soc/fsl/fsl_micfil.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,8 @@ static int micfil_set_quality(struct fsl_micfil *micfil)
183183
case QUALITY_VLOW2:
184184
qsel = MICFIL_QSEL_VLOW2_QUALITY;
185185
break;
186+
default:
187+
return -EINVAL;
186188
}
187189

188190
return regmap_update_bits(micfil->regmap, REG_MICFIL_CTRL2,

0 commit comments

Comments
 (0)