Skip to content

Commit b08e020

Browse files
committed
io_uring/rw: don't gate retry on completion context
nvme multipath reports that they see spurious -EAGAIN bubbling back to userspace, which is caused by how they handle retries internally through a kworker. However, any data that needs preserving or importing for a read/write request has always been done so at prep time, and we can sanely skip this check. Reported-by: "Haeuptle, Michael" <[email protected]> Link: https://lore.kernel.org/io-uring/DS7PR84MB31105C2C63CFA47BE8CBD6EE95102@DS7PR84MB3110.NAMPRD84.PROD.OUTLOOK.COM/ Signed-off-by: Jens Axboe <[email protected]>
1 parent d803d12 commit b08e020

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

io_uring/rw.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -475,12 +475,6 @@ static bool io_rw_should_reissue(struct io_kiocb *req)
475475
*/
476476
if (percpu_ref_is_dying(&ctx->refs))
477477
return false;
478-
/*
479-
* Play it safe and assume not safe to re-import and reissue if we're
480-
* not in the original thread group (or in task context).
481-
*/
482-
if (!same_thread_group(req->tctx->task, current) || !in_task())
483-
return false;
484478

485479
io_meta_restore(io, &rw->kiocb);
486480
iov_iter_restore(&io->iter, &io->iter_state);

0 commit comments

Comments
 (0)