Skip to content

Commit b28f47a

Browse files
committed
mtd: spinand: Improve spinand_info macros style
Let's assume all these macros should not have a trailing comma, this way the caller can use a more formal and usual C writing style, as reflected in the Macronix driver. Acked-by: Pratyush Yadav <[email protected]> Signed-off-by: Miquel Raynal <[email protected]>
1 parent ddc210c commit b28f47a

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

drivers/mtd/nand/spi/macronix.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ static const struct spinand_info macronix_spinand_table[] = {
187187
SPINAND_HAS_QE_BIT,
188188
SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
189189
macronix_ecc_get_status),
190-
SPINAND_CONT_READ(macronix_set_cont_read)
190+
SPINAND_CONT_READ(macronix_set_cont_read),
191191
SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
192192
macronix_set_read_retry)),
193193
SPINAND_INFO("MX35LF4GE4AD",
@@ -200,7 +200,7 @@ static const struct spinand_info macronix_spinand_table[] = {
200200
SPINAND_HAS_QE_BIT,
201201
SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
202202
macronix_ecc_get_status),
203-
SPINAND_CONT_READ(macronix_set_cont_read)
203+
SPINAND_CONT_READ(macronix_set_cont_read),
204204
SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
205205
macronix_set_read_retry)),
206206
SPINAND_INFO("MX35LF1G24AD",
@@ -328,7 +328,7 @@ static const struct spinand_info macronix_spinand_table[] = {
328328
SPINAND_HAS_QE_BIT,
329329
SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
330330
macronix_ecc_get_status),
331-
SPINAND_CONT_READ(macronix_set_cont_read)
331+
SPINAND_CONT_READ(macronix_set_cont_read),
332332
SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
333333
macronix_set_read_retry)),
334334
SPINAND_INFO("MX35UF2G14AC",
@@ -378,7 +378,7 @@ static const struct spinand_info macronix_spinand_table[] = {
378378
SPINAND_HAS_QE_BIT,
379379
SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
380380
macronix_ecc_get_status),
381-
SPINAND_CONT_READ(macronix_set_cont_read)
381+
SPINAND_CONT_READ(macronix_set_cont_read),
382382
SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
383383
macronix_set_read_retry)),
384384
SPINAND_INFO("MX35UF2GE4AC",
@@ -424,7 +424,7 @@ static const struct spinand_info macronix_spinand_table[] = {
424424
SPINAND_HAS_QE_BIT,
425425
SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
426426
macronix_ecc_get_status),
427-
SPINAND_CONT_READ(macronix_set_cont_read)
427+
SPINAND_CONT_READ(macronix_set_cont_read),
428428
SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
429429
macronix_set_read_retry)),
430430
SPINAND_INFO("MX35UF1GE4AC",

include/linux/mtd/spinand.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -502,10 +502,10 @@ struct spinand_info {
502502
}
503503

504504
#define SPINAND_SELECT_TARGET(__func) \
505-
.select_target = __func,
505+
.select_target = __func
506506

507507
#define SPINAND_CONT_READ(__set_cont_read) \
508-
.set_cont_read = __set_cont_read,
508+
.set_cont_read = __set_cont_read
509509

510510
#define SPINAND_FACT_OTP_INFO(__npages, __start_page, __ops) \
511511
.fact_otp = { \
@@ -526,8 +526,8 @@ struct spinand_info {
526526
}
527527

528528
#define SPINAND_READ_RETRY(__read_retries, __set_read_retry) \
529-
.read_retries = __read_retries, \
530-
.set_read_retry = __set_read_retry,
529+
.read_retries = __read_retries, \
530+
.set_read_retry = __set_read_retry
531531

532532
#define SPINAND_INFO(__model, __id, __memorg, __eccreq, __op_variants, \
533533
__flags, ...) \

0 commit comments

Comments
 (0)