Skip to content

Commit b5fbf92

Browse files
Dan CarpenterThomas Zimmermann
authored andcommitted
drm/client: Fix error code in drm_client_buffer_vmap_local()
This function accidentally returns zero/success on the failure path. It leads to locking issues and an uninitialized *map_copy in the caller. Fixes: b4b0193 ("drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Dmitry Osipenko <[email protected]> Reviewed-by: Thomas Zimmermann <[email protected]> Signed-off-by: Thomas Zimmermann <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 75c3e8a commit b5fbf92

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/drm_client.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
355355

356356
err_drm_gem_vmap_unlocked:
357357
drm_gem_unlock(gem);
358-
return 0;
358+
return ret;
359359
}
360360
EXPORT_SYMBOL(drm_client_buffer_vmap_local);
361361

0 commit comments

Comments
 (0)