Skip to content

Commit d286008

Browse files
committed
drm/amdgpu: Fix APU handling in amdgpu_pm_load_smu_firmware()
We only need to skip this on modern APUs. It's required on older APUs as it's where start_smu gets called from. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3502 Fixes: 064d924 ("drm/amd/pm: avoid to load smu firmware for APUs") Reviewed-by: Tim Huang <[email protected]> Signed-off-by: Alex Deucher <[email protected]> Cc: Tim Huang <[email protected]> (cherry picked from commit 608d886)
1 parent 9038e25 commit d286008

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/gpu/drm/amd/pm/amdgpu_dpm.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,8 @@ int amdgpu_pm_load_smu_firmware(struct amdgpu_device *adev, uint32_t *smu_versio
618618
const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
619619
int r = 0;
620620

621-
if (!pp_funcs || !pp_funcs->load_firmware || adev->flags & AMD_IS_APU)
621+
if (!pp_funcs || !pp_funcs->load_firmware ||
622+
(is_support_sw_smu(adev) && (adev->flags & AMD_IS_APU)))
622623
return 0;
623624

624625
mutex_lock(&adev->pm.mutex);

0 commit comments

Comments
 (0)