drm/amdkfd: Insert missing TLB flush on GFX10 and later

hkasivis · alexdeucher · commit edcfe22985d0 · 2023-09-12T17:45:40.000-04:00
Heavy-weight TLB flush is required after unmap on all GPUs for
correctness and security.

Signed-off-by: Harish Kasiviswanathan &lt;Harish.Kasiviswanathan@amd.com&gt;
Reviewed-by: Felix Kuehling &lt;Felix.Kuehling@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Cc: stable@vger.kernel.org
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
@@ -1466,8 +1466,7 @@ void kfd_flush_tlb(struct kfd_process_device *pdd, enum TLB_FLUSH_TYPE type);
 
 static inline bool kfd_flush_tlb_after_unmap(struct kfd_dev *dev)
 {
-	return KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 3) ||
-	       KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 2) ||
+	return KFD_GC_VERSION(dev) > IP_VERSION(9, 4, 2) ||
 	       (KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 1) && dev->sdma_fw_version >= 18) ||
 	       KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 0);
 }

Original file line number	Diff line number	Diff line change
`@@ -1466,8 +1466,7 @@ void kfd_flush_tlb(struct kfd_process_device *pdd, enum TLB_FLUSH_TYPE type);`
`1466`	`1466`
`1467`	`1467`	`static inline bool kfd_flush_tlb_after_unmap(struct kfd_dev *dev)`
`1468`	`1468`	`{`
`1469`		`- return KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 3) \|\|`
`1470`		`- KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 2) \|\|`
	`1469`	`+ return KFD_GC_VERSION(dev) > IP_VERSION(9, 4, 2) \|\|`
`1471`	`1470`	`(KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 1) && dev->sdma_fw_version >= 18) \|\|`
`1472`	`1471`	`KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 0);`
`1473`	`1472`	`}`