Skip to content

Commit efa6b8d

Browse files
Geliang Tangmatttbe
authored andcommitted
bpf: Export mptcp packet scheduler helpers
This patch adds a new struct btf_kfunc_id_set for MPTCP scheduler. Add mptcp_subflow_set_scheduled() and mptcp_sched_data_set_contexts() helpers into this id_set, and register it in bpf_mptcp_kfunc_init() to make sure these helpers can be accessed from the BPF context. Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Geliang Tang <[email protected]>
1 parent e73fb25 commit efa6b8d

File tree

3 files changed

+27
-2
lines changed

3 files changed

+27
-2
lines changed

net/mptcp/bpf.c

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,11 @@ bpf_mptcp_subflow_ctx_by_pos(const struct mptcp_sched_data *data, unsigned int p
298298
return data->contexts[pos];
299299
}
300300

301+
__bpf_kfunc static bool bpf_mptcp_subflow_queues_empty(struct sock *sk)
302+
{
303+
return tcp_rtx_queue_empty(sk);
304+
}
305+
301306
__bpf_kfunc_end_defs();
302307

303308
BTF_KFUNCS_START(bpf_mptcp_common_kfunc_ids)
@@ -314,13 +319,31 @@ static const struct btf_kfunc_id_set bpf_mptcp_common_kfunc_set = {
314319
.set = &bpf_mptcp_common_kfunc_ids,
315320
};
316321

322+
BTF_KFUNCS_START(bpf_mptcp_sched_kfunc_ids)
323+
BTF_ID_FLAGS(func, mptcp_subflow_set_scheduled)
324+
BTF_ID_FLAGS(func, bpf_mptcp_subflow_ctx_by_pos)
325+
BTF_ID_FLAGS(func, mptcp_subflow_active)
326+
BTF_ID_FLAGS(func, mptcp_set_timeout)
327+
BTF_ID_FLAGS(func, mptcp_wnd_end)
328+
BTF_ID_FLAGS(func, tcp_stream_memory_free)
329+
BTF_ID_FLAGS(func, bpf_mptcp_subflow_queues_empty)
330+
BTF_ID_FLAGS(func, mptcp_pm_subflow_chk_stale)
331+
BTF_KFUNCS_END(bpf_mptcp_sched_kfunc_ids)
332+
333+
static const struct btf_kfunc_id_set bpf_mptcp_sched_kfunc_set = {
334+
.owner = THIS_MODULE,
335+
.set = &bpf_mptcp_sched_kfunc_ids,
336+
};
337+
317338
static int __init bpf_mptcp_kfunc_init(void)
318339
{
319340
int ret;
320341

321342
ret = register_btf_fmodret_id_set(&bpf_mptcp_fmodret_set);
322343
ret = ret ?: register_btf_kfunc_id_set(BPF_PROG_TYPE_CGROUP_SOCKOPT,
323344
&bpf_mptcp_common_kfunc_set);
345+
ret = ret ?: register_btf_kfunc_id_set(BPF_PROG_TYPE_STRUCT_OPS,
346+
&bpf_mptcp_sched_kfunc_set);
324347
#ifdef CONFIG_BPF_JIT
325348
ret = ret ?: register_bpf_struct_ops(&bpf_mptcp_sched_ops, mptcp_sched_ops);
326349
#endif

net/mptcp/protocol.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ DEFINE_PER_CPU(struct mptcp_delegated_action, mptcp_delegated_actions);
5050
static struct net_device mptcp_napi_dev;
5151

5252
/* Returns end sequence number of the receiver's advertised window */
53-
static u64 mptcp_wnd_end(const struct mptcp_sock *msk)
53+
u64 mptcp_wnd_end(const struct mptcp_sock *msk)
5454
{
5555
return READ_ONCE(msk->wnd_end);
5656
}
@@ -423,7 +423,7 @@ static long mptcp_timeout_from_subflow(const struct mptcp_subflow_context *subfl
423423
inet_csk(ssk)->icsk_timeout - jiffies : 0;
424424
}
425425

426-
static void mptcp_set_timeout(struct sock *sk)
426+
void mptcp_set_timeout(struct sock *sk)
427427
{
428428
struct mptcp_subflow_context *subflow;
429429
long tout = 0;

net/mptcp/protocol.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -713,6 +713,8 @@ void __mptcp_subflow_send_ack(struct sock *ssk);
713713
void mptcp_subflow_reset(struct sock *ssk);
714714
void mptcp_subflow_queue_clean(struct sock *sk, struct sock *ssk);
715715
void mptcp_sock_graft(struct sock *sk, struct socket *parent);
716+
u64 mptcp_wnd_end(const struct mptcp_sock *msk);
717+
void mptcp_set_timeout(struct sock *sk);
716718
struct mptcp_subflow_context *
717719
bpf_mptcp_subflow_ctx_by_pos(const struct mptcp_sched_data *data, unsigned int pos);
718720
struct sock *__mptcp_nmpc_sk(struct mptcp_sock *msk);

0 commit comments

Comments
 (0)