Skip to content

Commit f1774d9

Browse files
calebsanderaxboe
authored andcommitted
io_uring/cmd: axe duplicate io_uring_cmd_import_fixed_vec() declaration
io_uring_cmd_import_fixed_vec() is declared in both include/linux/io_uring/cmd.h and io_uring/uring_cmd.h. The declarations are identical (if redundant) for CONFIG_IO_URING=y. But if CONFIG_IO_URING=N, include/linux/io_uring/cmd.h declares the function as static inline while io_uring/uring_cmd.h declares it as extern. This causes linker errors if the declaration in io_uring/uring_cmd.h is used. Remove the declaration in io_uring/uring_cmd.h to avoid linker errors and prevent the declarations getting out of sync. Signed-off-by: Caleb Sander Mateos <[email protected]> Fixes: ef49027 ("io_uring/cmd: introduce io_uring_cmd_import_fixed_vec") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
1 parent d871198 commit f1774d9

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

io_uring/uring_cmd.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,3 @@ bool io_uring_try_cancel_uring_cmd(struct io_ring_ctx *ctx,
1717
struct io_uring_task *tctx, bool cancel_all);
1818

1919
void io_cmd_cache_free(const void *entry);
20-
21-
int io_uring_cmd_import_fixed_vec(struct io_uring_cmd *ioucmd,
22-
const struct iovec __user *uvec,
23-
size_t uvec_segs,
24-
int ddir, struct iov_iter *iter,
25-
unsigned issue_flags);

0 commit comments

Comments
 (0)