Skip to content

Commit c8eee88

Browse files
ArtemySkrebkovdhawalsr
authored andcommitted
Apply review remarks
1 parent 64fe18d commit c8eee88

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

mlir/lib/Dialect/SCF/Transforms/StructuralTypeConversions.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,11 @@ class ConvertIndexSwitchOpTypes
201201
convertSourceOp(IndexSwitchOp op, OneToNOpAdaptor adaptor,
202202
ConversionPatternRewriter &rewriter,
203203
TypeRange dstTypes) const {
204-
auto newOp = rewriter.create<IndexSwitchOp>(
205-
op.getLoc(), dstTypes, op.getArg(), op.getCases(), op.getNumCases());
204+
auto newOp =
205+
IndexSwitchOp::create(rewriter, op.getLoc(), dstTypes, op.getArg(),
206+
op.getCases(), op.getNumCases());
206207

207208
for (unsigned i = 0u; i < op.getNumRegions(); i++) {
208-
if (failed(rewriter.convertRegionTypes(&op.getRegion(i), *typeConverter)))
209-
return std::nullopt;
210209
auto &dstRegion = newOp.getRegion(i);
211210
rewriter.inlineRegionBefore(op.getRegion(i), dstRegion, dstRegion.end());
212211
}

mlir/test/Dialect/SparseTensor/scf_1_N_conversion.mlir

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ func.func @while(%arg0: tensor<1024xf32, #SparseVector>, %c: i1) -> tensor<1024x
103103
// CHECK-SAME: %[[VAL_C_4:.*12]]: !sparse_tensor.storage_specifier
104104

105105
// CHECK: %[[RES:.*]]:4 = scf.index_switch %[[PRED]]
106+
// CHECK-SAME: -> memref<?xindex>, memref<?xindex>, memref<?xf32>, !sparse_tensor.storage_specifier
106107
// CHECK: case 1 {
107108
// CHECK: scf.yield %[[VAL_A_1]], %[[VAL_A_2]], %[[VAL_A_3]], %[[VAL_A_4]]
108109
// CHECK: case 2 {

0 commit comments

Comments
 (0)