fix: base extent relies on size of T and not std::uint32_t

samvangysegem · samvangysegem · commit 699fb9de85f1 · 2024-10-30T21:51:15.000+01:00
Signed-off-by: Sam Van Gysegem &lt;sam.vgysegem@gmail.com&gt;
diff --git a/include/msg/field.hpp b/include/msg/field.hpp
@@ -215,7 +215,7 @@ struct bits_locator_t {
     template <typename T> constexpr static auto extent_in() -> std::size_t {
         constexpr auto msb = Lsb + BitSize - 1;
         constexpr auto msb_extent = (msb + CHAR_BIT - 1) / CHAR_BIT;
-        constexpr auto base_extent = Index * sizeof(std::uint32_t);
+        constexpr auto base_extent = Index * sizeof(T);
         constexpr auto extent = base_extent + msb_extent;
         return (extent + sizeof(T) - 1) / sizeof(T);
     }

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ struct bits_locator_t {`
`215`	`215`	`template <typename T> constexpr static auto extent_in() -> std::size_t {`
`216`	`216`	`constexpr auto msb = Lsb + BitSize - 1;`
`217`	`217`	`constexpr auto msb_extent = (msb + CHAR_BIT - 1) / CHAR_BIT;`
`218`		`- constexpr auto base_extent = Index * sizeof(std::uint32_t);`
	`218`	`+ constexpr auto base_extent = Index * sizeof(T);`
`219`	`219`	`constexpr auto extent = base_extent + msb_extent;`
`220`	`220`	`return (extent + sizeof(T) - 1) / sizeof(T);`
`221`	`221`	`}`