Skip to content

✨ Allow overriding the mipi message type #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

✨ Allow overriding the mipi message type #688

merged 1 commit into from
Feb 12, 2025
+253 −133

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Feb 11, 2025

Problem:

  • Mipi short messages do not contain anything except the string id: no module id, no severity, etc. A client may want this information, so may not want to automatically use the short message.

Solution:

  • Allow the logging environment to supply a message builder for mipi.

@elbeno
✨ Allow overriding the mipi message type
bddece0 
Problem:
- Mipi short messages do not contain anything except the string id: no module
  id, no severity, etc. A client may want this information, so may not want to
  automatically use the short message.

Solution:
- Allow the logging environment to supply a message builder for mipi.
mjcaisse-intel
mjcaisse-intel approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@mjcaisse-intel mjcaisse-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@elbeno elbeno merged commit faedd52 into intel:main Feb 12, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcaisse-intel mjcaisse-intel mjcaisse-intel approved these changes

@lukevalenty lukevalenty Awaiting requested review from lukevalenty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elbeno @mjcaisse-intel