⬆️ Update stdx #689
Merged
⬆️ Update stdx #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - LLVM18 clang-tidy flags `handled` as able to be declared `const`. This is wrong, but what we're actually doing here is better expressed as `transform_reduce` on the bitset. Solution: - Use `transform_reduce`. Note: - `transform_reduce` is the operation here because we do not want to shortcut handling the message. `any_of` would be correct for that use case.
mjcaisse-intel
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
handledas able to be declaredconst. This is wrong, but what we're actually doing here is better expressed astransform_reduceon the bitset.Solution:
transform_reduce.Note:
transform_reduceis the operation here because we do not want to shortcut handling the message.any_ofwould be correct for that use case.