Improve safety of pattern reading in appendMemoryFill()

PatrykWrobelDev · Compute-Runtime-Automation · commit 140e744f4b12 · 2022-08-04T00:30:05.000+02:00
Related-To: NEO-7233
Signed-off-by: Wrobel, Patryk &lt;patryk.wrobel@intel.com&gt;
diff --git a/level_zero/core/source/cmdlist/cmdlist_hw.inl b/level_zero/core/source/cmdlist/cmdlist_hw.inl
@@ -1541,7 +1541,7 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::appendMemoryFill(void *ptr,
             return ZE_RESULT_ERROR_UNKNOWN;
         }
 
-        uint32_t value = *(reinterpret_cast<uint32_t *>(const_cast<void *>(pattern)));
+        uint32_t value = *(reinterpret_cast<const unsigned char *>(pattern));
         builtinFunction->setArgBufferWithAlloc(0, dstAllocation.alignedAllocationPtr, dstAllocation.alloc);
         builtinFunction->setArgumentValue(1, sizeof(dstAllocation.offset), &dstAllocation.offset);
         builtinFunction->setArgumentValue(2, sizeof(value), &value);

Original file line number	Diff line number	Diff line change
`@@ -1541,7 +1541,7 @@ ze_result_t CommandListCoreFamily<gfxCoreFamily>::appendMemoryFill(void *ptr,`
`1541`	`1541`	`return ZE_RESULT_ERROR_UNKNOWN;`
`1542`	`1542`	`}`
`1543`	`1543`
`1544`		`- uint32_t value = (reinterpret_cast<uint32_t >(const_cast<void *>(pattern)));`
	`1544`	`+ uint32_t value = (reinterpret_cast<const unsigned char >(pattern));`
`1545`	`1545`	`builtinFunction->setArgBufferWithAlloc(0, dstAllocation.alignedAllocationPtr, dstAllocation.alloc);`
`1546`	`1546`	`builtinFunction->setArgumentValue(1, sizeof(dstAllocation.offset), &dstAllocation.offset);`
`1547`	`1547`	`builtinFunction->setArgumentValue(2, sizeof(value), &value);`