Skip to content

Commit 1ef5161

Browse files
Correct check if binding table prefetch is supported
Remove redundant resetBindingTablePrefetch function, disable binding table prefetch on xe platforms in OCL. Signed-off-by: Kamil Kopryk <[email protected]>
1 parent 34a7059 commit 1ef5161

File tree

4 files changed

+2
-13
lines changed

4 files changed

+2
-13
lines changed

opencl/source/helpers/hardware_commands_helper.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ struct HardwareCommandsHelper : public PerThreadDataHelper {
106106
size_t &sizePerThreadDataTotal,
107107
size_t &localWorkItems);
108108

109-
inline static bool resetBindingTablePrefetch();
110-
111109
static size_t getSizeRequiredCS();
112110
static size_t getSizeRequiredForCacheFlush(const CommandQueue &commandQueue, const Kernel *kernel, uint64_t postSyncAddress);
113111

opencl/source/helpers/hardware_commands_helper_base.inl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,8 @@ size_t HardwareCommandsHelper<GfxFamily>::sendIndirectState(
249249
uint64_t offsetInterfaceDescriptor = offsetInterfaceDescriptorTable + interfaceDescriptorIndex * sizeof(INTERFACE_DESCRIPTOR_DATA);
250250

251251
auto bindingTablePrefetchSize = std::min(31u, static_cast<uint32_t>(kernel.getNumberOfBindingTableStates()));
252-
if (resetBindingTablePrefetch()) {
252+
253+
if (!EncodeSurfaceState<GfxFamily>::doBindingTablePrefetch()) {
253254
bindingTablePrefetchSize = 0;
254255
}
255256

opencl/source/helpers/hardware_commands_helper_bdw_and_later.inl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,6 @@ size_t HardwareCommandsHelper<GfxFamily>::sendCrossThreadData(
138138
return offsetCrossThreadData + static_cast<size_t>(indirectHeap.getHeapGpuStartOffset());
139139
}
140140

141-
template <typename GfxFamily>
142-
bool HardwareCommandsHelper<GfxFamily>::resetBindingTablePrefetch() {
143-
return !EncodeSurfaceState<GfxFamily>::doBindingTablePrefetch();
144-
}
145-
146141
template <typename GfxFamily>
147142
void HardwareCommandsHelper<GfxFamily>::setInterfaceDescriptorOffset(
148143
WALKER_TYPE *walkerCmd,

opencl/source/helpers/hardware_commands_helper_xehp_and_later.inl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,6 @@ size_t HardwareCommandsHelper<GfxFamily>::sendCrossThreadData(
154154
return offsetCrossThreadData + static_cast<size_t>(is64bit ? indirectHeap.getHeapGpuStartOffset() : indirectHeap.getHeapGpuBase());
155155
}
156156

157-
template <typename GfxFamily>
158-
bool HardwareCommandsHelper<GfxFamily>::resetBindingTablePrefetch() {
159-
return false;
160-
}
161-
162157
template <typename GfxFamily>
163158
void HardwareCommandsHelper<GfxFamily>::setInterfaceDescriptorOffset(
164159
WALKER_TYPE *walkerCmd,

0 commit comments

Comments
 (0)