Dont print error on IOCTL entry after success

This to reduce verbosity and avoid confusions when reading logs.

Signed-off-by: Jaime Arteaga <[email protected]>

Author: Jaime Arteaga

opencl/test/unit_test/linux/main_linux_dll.cpp

@@ -199,7 +199,33 @@ TEST_F(DrmSimpleTests, givenPrintIoctlEntriesWhenCallIoctlThenIoctlIsPrinted) {
     drm->destroyDrmContext(contextId);
 
     std::string output = ::testing::internal::GetCapturedStdout();
-    EXPECT_STREQ(output.c_str(), "IOCTL DRM_IOCTL_I915_GEM_CONTEXT_DESTROY called\nIOCTL DRM_IOCTL_I915_GEM_CONTEXT_DESTROY returns 0, errno 9(Bad file descriptor)\n");
+    EXPECT_STREQ(output.c_str(), "IOCTL DRM_IOCTL_I915_GEM_CONTEXT_DESTROY called\nIOCTL DRM_IOCTL_I915_GEM_CONTEXT_DESTROY returns 0\n");
+}
+
+struct DrmFailedIoctlTests : public ::testing::Test {
+    void SetUp() override {
+        if (deviceDescriptorTable[0].deviceId == 0) {
+            GTEST_SKIP();
+        }
+    }
+};
+
+TEST_F(DrmFailedIoctlTests, givenPrintIoctlEntriesWhenCallFailedIoctlThenExpectedIoctlIsPrinted) {
+    ::testing::internal::CaptureStdout();
+
+    auto executionEnvironment = std::make_unique<ExecutionEnvironment>();
+    executionEnvironment->prepareRootDeviceEnvironments(1);
+    auto drm = DrmWrap::createDrm(*executionEnvironment->rootDeviceEnvironments[0]);
+
+    DebugManagerStateRestore restorer;
+    DebugManager.flags.PrintIoctlEntries.set(true);
+
+    uint32_t contextId = 1u;
+    uint32_t vmId = 100u;
+    drm->queryVmId(contextId, vmId);
+
+    std::string output = ::testing::internal::GetCapturedStdout();
+    EXPECT_STREQ(output.c_str(), "IOCTL DRM_IOCTL_I915_GEM_CONTEXT_GETPARAM called\nIOCTL DRM_IOCTL_I915_GEM_CONTEXT_GETPARAM returns -1, errno 9(Bad file descriptor)\n");
 }
 
 TEST_F(DrmSimpleTests, givenPrintIoctlTimesWhenCallIoctlThenStatisticsAreGathered) {

shared/source/os_interface/linux/drm_neo.cpp

@@ -240,7 +240,13 @@ int Drm::ioctl(unsigned long request, void *arg) {
         }
 
         if (printIoctl) {
-            printf("IOCTL %s returns %d, errno %d(%s)\n", IoctlToStringHelper::getIoctlString(request).c_str(), ret, returnedErrno, strerror(returnedErrno));
+            if (ret == 0) {
+                printf("IOCTL %s returns %d\n",
+                       IoctlToStringHelper::getIoctlString(request).c_str(), ret);
+            } else {
+                printf("IOCTL %s returns %d, errno %d(%s)\n",
+                       IoctlToStringHelper::getIoctlString(request).c_str(), ret, returnedErrno, strerror(returnedErrno));
+            }
         }
 
     } while (ret == -1 && (returnedErrno == EINTR || returnedErrno == EAGAIN || returnedErrno == EBUSY));