Skip to content

Commit 390ec9f

Browse files
Jaime ArteagaCompute-Runtime-Automation
authored andcommitted
Return ZE_MEMORY_TYPE_UNKNOWN for non-runtime allocated pointers
This aligns more to spec definition Change-Id: I3f6aaf50945ef82fa5ffe8f400972e944ad03e2b Signed-off: Jaime Arteaga <[email protected]>
1 parent 497ebf1 commit 390ec9f

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

level_zero/core/source/driver/driver_handle_imp.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,9 @@ ze_result_t DriverHandleImp::getMemAllocProperties(const void *ptr,
9999
}
100100
return ZE_RESULT_SUCCESS;
101101
}
102-
return ZE_RESULT_ERROR_INVALID_ARGUMENT;
102+
pMemAllocProperties->type = ZE_MEMORY_TYPE_UNKNOWN;
103+
104+
return ZE_RESULT_SUCCESS;
103105
}
104106

105107
DriverHandleImp::~DriverHandleImp() {

level_zero/core/test/unit_tests/sources/memory/test_memory.cpp

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,21 @@ TEST_F(MemoryTest, givenHostPointerThenDriverGetAllocPropertiesReturnsNullDevice
8989
ASSERT_EQ(result, ZE_RESULT_SUCCESS);
9090
}
9191

92+
TEST_F(MemoryTest, givenSystemAllocatedPointerThenDriverGetAllocPropertiesReturnsUnknownType) {
93+
size_t size = 10;
94+
int *ptr = new int[size];
95+
96+
ze_memory_allocation_properties_t memoryProperties = {};
97+
memoryProperties.version = ZE_MEMORY_ALLOCATION_PROPERTIES_VERSION_CURRENT;
98+
ze_device_handle_t deviceHandle;
99+
ze_result_t result = driverHandle->getMemAllocProperties(ptr, &memoryProperties, &deviceHandle);
100+
101+
EXPECT_EQ(ZE_RESULT_SUCCESS, result);
102+
EXPECT_EQ(memoryProperties.type, ZE_MEMORY_TYPE_UNKNOWN);
103+
104+
delete[] ptr;
105+
}
106+
92107
TEST_F(MemoryTest, givenSharedPointerAndDeviceHandleAsNullThenDriverReturnsSuccessAndReturnsPointerToSharedAllocation) {
93108
size_t size = 10;
94109
size_t alignment = 1u;

0 commit comments

Comments
 (0)