Skip to content

Commit 49c828e

Browse files
Revert "L0debug - Canonize SBA in single address space mode"
This reverts commit f067145. Signed-off-by: Compute-Runtime-Validation <[email protected]>
1 parent f0a9533 commit 49c828e

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

shared/source/debugger/debugger_l0.inl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ void DebuggerL0Hw<GfxFamily>::captureStateBaseAddress(NEO::LinearStream &cmdStre
4141
sbaCanonized.IndirectObjectBaseAddress, sbaCanonized.InstructionBaseAddress, sbaCanonized.BindlessSurfaceStateBaseAddress);
4242

4343
if (singleAddressSpaceSbaTracking) {
44-
programSbaTrackingCommandsSingleAddressSpace(cmdStream, sbaCanonized);
44+
programSbaTrackingCommandsSingleAddressSpace(cmdStream, sba);
4545
} else {
4646
if (sbaCanonized.GeneralStateBaseAddress) {
4747
auto generalStateBaseAddress = sbaCanonized.GeneralStateBaseAddress;

shared/test/unit_test/debugger/test_l0_debugger_single_address_space.cpp

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*/
77

88
#include "shared/source/command_container/command_encoder.h"
9-
#include "shared/source/gmm_helper/gmm_helper.h"
109
#include "shared/test/common/cmd_parse/gen_cmd_parse.h"
1110
#include "shared/test/common/fixtures/device_fixture.h"
1211
#include "shared/test/common/helpers/debug_manager_state_restore.h"
@@ -242,13 +241,12 @@ HWTEST2_F(SingleAddressSpaceFixture, GivenOneNonZeroSbaAddressesWhenProgrammingS
242241
cmdStream.replaceGraphicsAllocation(streamAllocation);
243242
cmdStream.replaceBuffer(streamAllocation->getUnderlyingBuffer(), streamAllocation->getUnderlyingBufferSize());
244243

245-
uint64_t ssba = 0x0000800011112222;
244+
uint64_t ssba = 0x1234567000;
246245

247246
NEO::Debugger::SbaAddresses sbaAddresses = {0};
248247
sbaAddresses.SurfaceStateBaseAddress = ssba;
249248

250-
debugger->singleAddressSpaceSbaTracking = true;
251-
debugger->captureStateBaseAddress(cmdStream, sbaAddresses);
249+
debugger->programSbaTrackingCommandsSingleAddressSpace(cmdStream, sbaAddresses);
252250

253251
GenCmdList cmdList;
254252
ASSERT_TRUE(FamilyType::PARSE::parseCommandBuffer(cmdList, cmdStream.getCpuBase(), cmdStream.getUsed()));
@@ -291,17 +289,9 @@ HWTEST2_F(SingleAddressSpaceFixture, GivenOneNonZeroSbaAddressesWhenProgrammingS
291289

292290
itor = find<MI_STORE_DATA_IMM *>(itor, cmdList.end());
293291
ASSERT_NE(cmdList.end(), itor);
294-
auto lowDword = genCmdCast<MI_STORE_DATA_IMM *>(*itor)->getDataDword0();
295-
itor++;
296292

297293
itor = find<MI_STORE_DATA_IMM *>(itor, cmdList.end());
298294
ASSERT_NE(cmdList.end(), itor);
299-
auto highDword = genCmdCast<MI_STORE_DATA_IMM *>(*itor)->getDataDword0();
300-
301-
uint64_t foundSsba = ((static_cast<uint64_t>(highDword) & 0xffffffff) << 32) | lowDword;
302-
const auto gmmHelper = pDevice->getGmmHelper();
303-
const auto ssbaCanonized = gmmHelper->canonize(ssba);
304-
EXPECT_EQ(ssbaCanonized, foundSsba);
305295

306296
itor = find<MI_ARB_CHECK *>(itor, cmdList.end());
307297
ASSERT_NE(cmdList.end(), itor);

0 commit comments

Comments
 (0)