sysman: fix unintialized pointer access in firmware module

vilvarajintel · Compute-Runtime-Automation · commit 4cf3bb6a0494 · 2021-02-15T13:58:05.000+01:00
Signed-off-by: T J Vivek Vilvaraj &lt;t.j.vivek.vilvaraj@intel.com&gt;
diff --git a/level_zero/tools/source/sysman/firmware/linux/os_firmware_imp.cpp b/level_zero/tools/source/sysman/firmware/linux/os_firmware_imp.cpp
@@ -34,8 +34,11 @@ ze_result_t OsFirmware::getSupportedFwTypes(std::vector<std::string> &supportedF
     return ZE_RESULT_SUCCESS;
 }
 bool LinuxFirmwareImp::isFirmwareSupported(void) {
-    isFWInitalized = ((ZE_RESULT_SUCCESS == pFwInterface->fwDeviceInit()) ? true : false);
-    return this->isFWInitalized;
+    if (pFwInterface != nullptr) {
+        isFWInitalized = ((ZE_RESULT_SUCCESS == pFwInterface->fwDeviceInit()) ? true : false);
+        return this->isFWInitalized;
+    }
+    return false;
 }
 
 void LinuxFirmwareImp::osGetFwProperties(zes_firmware_properties_t *pProperties) {

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,11 @@ ze_result_t OsFirmware::getSupportedFwTypes(std::vector<std::string> &supportedF`
`34`	`34`	`return ZE_RESULT_SUCCESS;`
`35`	`35`	`}`
`36`	`36`	`bool LinuxFirmwareImp::isFirmwareSupported(void) {`
`37`		`- isFWInitalized = ((ZE_RESULT_SUCCESS == pFwInterface->fwDeviceInit()) ? true : false);`
`38`		`- return this->isFWInitalized;`
	`37`	`+ if (pFwInterface != nullptr) {`
	`38`	`+ isFWInitalized = ((ZE_RESULT_SUCCESS == pFwInterface->fwDeviceInit()) ? true : false);`
	`39`	`+ return this->isFWInitalized;`
	`40`	`+ }`
	`41`	`+ return false;`
`39`	`42`	`}`
`40`	`43`
`41`	`44`	`void LinuxFirmwareImp::osGetFwProperties(zes_firmware_properties_t *pProperties) {`