Skip to content

Commit 4f94984

Browse files
Re-enable tg dispatch size heuristic
Related-To: NEO-6989 Signed-off-by: Dominik Dabek <[email protected]>
1 parent 496f785 commit 4f94984

File tree

2 files changed

+2
-28
lines changed

2 files changed

+2
-28
lines changed

shared/source/xe_hpc_core/command_encoder_xe_hpc_core.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ void EncodeDispatchKernel<Family>::adjustInterfaceDescriptorData(INTERFACE_DESCR
3636

3737
if (hwInfoConfig.isDisableOverdispatchAvailable(hwInfo)) {
3838
interfaceDescriptor.setThreadGroupDispatchSize(INTERFACE_DESCRIPTOR_DATA::THREAD_GROUP_DISPATCH_SIZE_TG_SIZE_1);
39-
bool adjustTGDispatchSize = hwInfo.gtSystemInfo.MaxDualSubSlicesSupported == hwInfo.gtSystemInfo.DualSubSliceCount;
39+
bool adjustTGDispatchSize = true;
4040
if (DebugManager.flags.AdjustThreadGroupDispatchSize.get() != -1) {
4141
adjustTGDispatchSize = !!DebugManager.flags.AdjustThreadGroupDispatchSize.get();
4242
}

shared/test/unit_test/xe_hpc_core/test_encode_xe_hpc_core.cpp

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -510,28 +510,6 @@ XE_HPC_CORETEST_F(EncodeKernelXeHpcCoreTest, givenCleanHeapsAndSlmNotChangedAndU
510510
(gmmHelper->getMOCS(GMM_RESOURCE_USAGE_OCL_BUFFER_CACHELINE_MISALIGNED)));
511511
}
512512

513-
XE_HPC_CORETEST_F(EncodeKernelXeHpcCoreTest, givenInterfaceDescriptorDataAndNonSymmetricalSkuWhenAdjustInterfaceDescriptorDataIsCalledThenThreadGroupDispatchSizeIsCorrectlySet) {
514-
using INTERFACE_DESCRIPTOR_DATA = typename FamilyType::INTERFACE_DESCRIPTOR_DATA;
515-
516-
INTERFACE_DESCRIPTOR_DATA iddArg = FamilyType::cmdInitInterfaceDescriptorData;
517-
const auto &hwInfoConfig = *HwInfoConfig::get(productFamily);
518-
auto hwInfo = pDevice->getHardwareInfo();
519-
hwInfo.gtSystemInfo.DualSubSliceCount = 32u;
520-
ASSERT_NE(hwInfo.gtSystemInfo.DualSubSliceCount, hwInfo.gtSystemInfo.MaxDualSubSlicesSupported);
521-
522-
for (const auto &revision : {REVISION_A0, REVISION_B}) {
523-
hwInfo.platform.usRevId = hwInfoConfig.getHwRevIdFromStepping(revision, hwInfo);
524-
525-
EncodeDispatchKernel<FamilyType>::adjustInterfaceDescriptorData(iddArg, *pDevice, hwInfo, 0, 0);
526-
527-
if (hwInfoConfig.isDisableOverdispatchAvailable(hwInfo)) {
528-
EXPECT_EQ(INTERFACE_DESCRIPTOR_DATA::THREAD_GROUP_DISPATCH_SIZE_TG_SIZE_1, iddArg.getThreadGroupDispatchSize());
529-
} else {
530-
EXPECT_EQ(INTERFACE_DESCRIPTOR_DATA::THREAD_GROUP_DISPATCH_SIZE_TG_SIZE_8, iddArg.getThreadGroupDispatchSize());
531-
}
532-
}
533-
}
534-
535513
XE_HPC_CORETEST_F(EncodeKernelXeHpcCoreTest, givenDispatchSizeSmallerOrEqualToAvailableThreadCountWhenAdjustInterfaceDescriptorDataIsCalledThenThreadGroupDispatchSizeIsCorrectlySet) {
536514
using INTERFACE_DESCRIPTOR_DATA = typename FamilyType::INTERFACE_DESCRIPTOR_DATA;
537515

@@ -593,11 +571,7 @@ XE_HPC_CORETEST_F(EncodeKernelXeHpcCoreTest, givenNumberOfThreadsInThreadGroupWh
593571

594572
EncodeDispatchKernel<FamilyType>::adjustInterfaceDescriptorData(iddArg, *pDevice, hwInfo, threadGroupCount, numGrf);
595573

596-
if (hwInfo.gtSystemInfo.MaxDualSubSlicesSupported == hwInfo.gtSystemInfo.DualSubSliceCount) {
597-
EXPECT_EQ(expectedThreadGroupDispatchSize, iddArg.getThreadGroupDispatchSize());
598-
} else {
599-
EXPECT_EQ(INTERFACE_DESCRIPTOR_DATA::THREAD_GROUP_DISPATCH_SIZE_TG_SIZE_1, iddArg.getThreadGroupDispatchSize());
600-
}
574+
EXPECT_EQ(expectedThreadGroupDispatchSize, iddArg.getThreadGroupDispatchSize());
601575
}
602576
}
603577

0 commit comments

Comments
 (0)