Skip to content

Commit 70b41cf

Browse files
Revert "Move semaphore to local memory on XE_HPG"
This reverts commit 94f3e54. Signed-off-by: Compute-Runtime-Validation <[email protected]>
1 parent 200fdfa commit 70b41cf

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

shared/source/helpers/extra_allocation_data_xehp_and_later.inl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,6 @@ void HwHelperHw<Family>::setExtraAllocationData(AllocationData &allocationData,
2828
allocationData.flags.requiresCpuAccess = false;
2929
allocationData.storageInfo.isLockable = false;
3030
}
31-
} else if (hwInfo.featureTable.flags.ftrLocalMemory &&
32-
(properties.allocationType == AllocationType::COMMAND_BUFFER ||
33-
properties.allocationType == AllocationType::RING_BUFFER ||
34-
properties.allocationType == AllocationType::SEMAPHORE_BUFFER)) {
35-
allocationData.flags.useSystemMemory = false;
36-
allocationData.flags.requiresCpuAccess = true;
3731
}
3832

3933
if (hwInfoConfig.allowStatelessCompression(hwInfo)) {

shared/test/unit_test/xe_hpg_core/hw_helper_tests_xe_hpg_core.cpp

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -89,30 +89,6 @@ XE_HPG_CORETEST_F(LriHelperTestsXeHpgCore, whenProgrammingLriCommandThenExpectMm
8989
EXPECT_TRUE(memcmp(lri, &expectedLri, sizeof(MI_LOAD_REGISTER_IMM)) == 0);
9090
}
9191

92-
XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, givenAllocDataWhenSetExtraAllocationDataThenSetLocalMemForProperTypes) {
93-
auto &hwHelper = HwHelper::get(renderCoreFamily);
94-
95-
for (int type = 0; type < static_cast<int>(AllocationType::COUNT); type++) {
96-
AllocationProperties allocProperties(0, 1, static_cast<AllocationType>(type), {});
97-
AllocationData allocData{};
98-
allocData.flags.useSystemMemory = true;
99-
allocData.flags.requiresCpuAccess = false;
100-
101-
hwHelper.setExtraAllocationData(allocData, allocProperties, *defaultHwInfo);
102-
103-
if (defaultHwInfo->featureTable.flags.ftrLocalMemory &&
104-
(allocProperties.allocationType == AllocationType::COMMAND_BUFFER ||
105-
allocProperties.allocationType == AllocationType::RING_BUFFER ||
106-
allocProperties.allocationType == AllocationType::SEMAPHORE_BUFFER)) {
107-
EXPECT_FALSE(allocData.flags.useSystemMemory);
108-
EXPECT_TRUE(allocData.flags.requiresCpuAccess);
109-
} else {
110-
EXPECT_TRUE(allocData.flags.useSystemMemory);
111-
EXPECT_FALSE(allocData.flags.requiresCpuAccess);
112-
}
113-
}
114-
}
115-
11692
XE_HPG_CORETEST_F(HwHelperTestXeHpgCore, GivenVariousValuesWhenAlignSlmSizeIsCalledThenCorrectValueIsReturned) {
11793
EXPECT_EQ(0u, HwHelperHw<FamilyType>::get().alignSlmSize(0));
11894
EXPECT_EQ(1024u, HwHelperHw<FamilyType>::get().alignSlmSize(1));

0 commit comments

Comments
 (0)