Do not create buffer when size is too big.

Resolves: NEO-3131
Change-Id: Icd37e7bc62719be5956b6a9435ab2fe7e0962c00
Signed-off-by: Krzysztof Gibala <[email protected]>

Author: kgibala

runtime/mem_obj/buffer.cpp

@@ -82,7 +82,14 @@ void Buffer::validateInputAndCreateBuffer(cl_context &context,
                                           void *hostPtr,
                                           cl_int &retVal,
                                           cl_mem &buffer) {
-    if (size == 0) {
+    Context *pContext = nullptr;
+    retVal = validateObjects(WithCastToInternal(context, &pContext));
+    if (retVal != CL_SUCCESS) {
+        return;
+    }
+
+    auto pDevice = pContext->getDevice(0);
+    if (size == 0 || size > pDevice->getDeviceInfo().maxMemAllocSize) {
         retVal = CL_INVALID_BUFFER_SIZE;
         return;
     }
@@ -99,12 +106,6 @@ void Buffer::validateInputAndCreateBuffer(cl_context &context,
         return;
     }
 
-    Context *pContext = nullptr;
-    retVal = validateObjects(WithCastToInternal(context, &pContext));
-    if (retVal != CL_SUCCESS) {
-        return;
-    }
-
     // create the buffer
     buffer = create(pContext, properties, size, hostPtr, retVal);
 }

unit_tests/api/cl_create_buffer_tests.cpp

@@ -208,6 +208,24 @@ TEST_F(clCreateBufferTests, GivenMemWriteOnlyFlagAndMemReadWriteFlagWhenCreating
     ASSERT_EQ(CL_INVALID_VALUE, retVal);
 }
 
+TEST_F(clCreateBufferTests, GivenBufferSizeOverMaxMemAllocSizeWhenCreatingBufferThenInvalidBufferSizeErrorIsReturned) {
+    auto pDevice = pContext->getDevice(0);
+    size_t size = static_cast<size_t>(pDevice->getDeviceInfo().maxMemAllocSize) + 1;
+
+    auto buffer = clCreateBuffer(pContext, CL_MEM_ALLOC_HOST_PTR, size, nullptr, &retVal);
+    EXPECT_EQ(CL_INVALID_BUFFER_SIZE, retVal);
+    EXPECT_EQ(nullptr, buffer);
+}
+
+TEST_F(clCreateBufferTests, GivenBufferSizeOverMaxMemAllocSizeWhenCreateBufferWithPropertiesINTELThenInvalidBufferSizeErrorIsReturned) {
+    auto pDevice = pContext->getDevice(0);
+    size_t size = static_cast<size_t>(pDevice->getDeviceInfo().maxMemAllocSize) + 1;
+
+    auto buffer = clCreateBufferWithPropertiesINTEL(pContext, nullptr, size, nullptr, &retVal);
+    EXPECT_EQ(CL_INVALID_BUFFER_SIZE, retVal);
+    EXPECT_EQ(nullptr, buffer);
+}
+
 TEST_F(clCreateBufferTests, GivenNullHostPointerAndMemCopyHostPtrFlagWhenCreatingBufferThenNullIsReturned) {
     cl_mem_flags flags = CL_MEM_USE_HOST_PTR;
     static const unsigned int bufferSize = 16;