Skip to content

Commit 78aeef8

Browse files
Add additional pipe control arguments check
Signed-off-by: Rafal Maziejuk <[email protected]>
1 parent aed1da7 commit 78aeef8

File tree

4 files changed

+19
-0
lines changed

4 files changed

+19
-0
lines changed

opencl/test/unit_test/helpers/hw_helper_tests.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1350,3 +1350,9 @@ HWTEST_F(HwHelperTest, givenRcsOrCcsEnabledWhenQueryingGpgpuEngineCountThenRetur
13501350
hwInfo.featureTable.ftrRcsNode = true;
13511351
EXPECT_EQ(4u, HwHelper::getGpgpuEnginesCount(hwInfo));
13521352
}
1353+
1354+
using isXeHpCoreOrBelow = IsAtMostProduct<IGFX_XE_HP_SDV>;
1355+
HWTEST2_F(HwHelperTest, givenXeHPAndBelowPlatformWhenCheckingIfAdditionalPipeControlArgsAreRequiredThenReturnFalse, isXeHpCoreOrBelow) {
1356+
auto &hwHelper = HwHelper::get(renderCoreFamily);
1357+
EXPECT_FALSE(hwHelper.additionalPipeControlArgsRequired());
1358+
}

shared/source/helpers/hw_helper.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ class HwHelper {
151151
virtual size_t getSingleTimestampPacketSize() const = 0;
152152
virtual void applyAdditionalCompressionSettings(Gmm &gmm, bool isNotCompressed) const = 0;
153153
virtual void applyRenderCompressionFlag(Gmm &gmm, uint32_t isRenderCompressed) const = 0;
154+
virtual bool additionalPipeControlArgsRequired() const = 0;
154155

155156
static uint32_t getSubDevicesCount(const HardwareInfo *pHwInfo);
156157
static uint32_t getGpgpuEnginesCount(const HardwareInfo &hwInfo);
@@ -383,6 +384,8 @@ class HwHelperHw : public HwHelper {
383384

384385
void applyRenderCompressionFlag(Gmm &gmm, uint32_t isRenderCompressed) const override;
385386

387+
bool additionalPipeControlArgsRequired() const override;
388+
386389
protected:
387390
LocalMemoryAccessMode getDefaultLocalMemoryAccessMode(const HardwareInfo &hwInfo) const override;
388391

shared/source/helpers/hw_helper_bdw_plus.inl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,4 +134,9 @@ inline void MemorySynchronizationCommands<GfxFamily>::setPipeControlExtraPropert
134134
template <typename GfxFamily>
135135
bool MemorySynchronizationCommands<GfxFamily>::isPipeControlWArequired(const HardwareInfo &hwInfo) { return false; }
136136

137+
template <typename GfxFamily>
138+
bool HwHelperHw<GfxFamily>::additionalPipeControlArgsRequired() const {
139+
return false;
140+
}
141+
137142
} // namespace NEO

shared/source/xe_hp_core/hw_helper_xe_hp_core.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,11 @@ void MemorySynchronizationCommands<Family>::setCacheFlushExtraProperties(PipeCon
204204
args.hdcPipelineFlush = true;
205205
}
206206

207+
template <>
208+
bool HwHelperHw<Family>::additionalPipeControlArgsRequired() const {
209+
return false;
210+
}
211+
207212
template class HwHelperHw<Family>;
208213
template class FlatBatchBufferHelperHw<Family>;
209214
template struct MemorySynchronizationCommands<Family>;

0 commit comments

Comments
 (0)