Skip to content

Commit 83f63e0

Browse files
Revert "Ocloc - fix binary output filename with "-output_no_suffix""
This reverts commit 3ca628c. Signed-off-by: Compute-Runtime-Validation <[email protected]>
1 parent 6f710bf commit 83f63e0

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

manifests/manifest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ components:
3838
dest_dir: kernels_bin
3939
type: git
4040
branch: kernels_bin
41-
revision: 1982-408
41+
revision: 1982-406
4242
kmdaf:
4343
branch: kmdaf
4444
dest_dir: kmdaf

opencl/test/unit_test/offline_compiler/offline_compiler_tests.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2597,7 +2597,7 @@ TEST(OfflineCompilerTest, givenOutputNoSuffixFlagAndNonEmptyOutputFileNameAndNon
25972597

25982598
mockOfflineCompiler.writeOutAllFiles();
25992599

2600-
const auto outputFileIt = mockOfflineCompiler.uniqueHelper->interceptedFiles.find("some_output_filename.bin");
2600+
const auto outputFileIt = mockOfflineCompiler.uniqueHelper->interceptedFiles.find("some_output_filename");
26012601
ASSERT_NE(mockOfflineCompiler.uniqueHelper->interceptedFiles.end(), outputFileIt);
26022602

26032603
EXPECT_EQ("12345678", outputFileIt->second);
@@ -2613,7 +2613,7 @@ TEST(OfflineCompilerTest, givenInputFileNameAndOutputNoSuffixFlagAndEmptyOutputF
26132613

26142614
mockOfflineCompiler.writeOutAllFiles();
26152615

2616-
const auto outputFileIt = mockOfflineCompiler.uniqueHelper->interceptedFiles.find("important_file.bin");
2616+
const auto outputFileIt = mockOfflineCompiler.uniqueHelper->interceptedFiles.find("important_file");
26172617
ASSERT_NE(mockOfflineCompiler.uniqueHelper->interceptedFiles.end(), outputFileIt);
26182618

26192619
EXPECT_EQ("12345678", outputFileIt->second);
@@ -2637,7 +2637,7 @@ TEST(OfflineCompilerTest, givenNonEmptyOutputDirectoryWhenWritingOutAllFilesTheD
26372637
EXPECT_EQ("/home/important", mockOfflineCompiler.createdDirs[1]);
26382638
EXPECT_EQ("/home/important/compilation", mockOfflineCompiler.createdDirs[2]);
26392639

2640-
const auto outputFileIt = mockOfflineCompiler.uniqueHelper->interceptedFiles.find("/home/important/compilation/some_output_filename.bin");
2640+
const auto outputFileIt = mockOfflineCompiler.uniqueHelper->interceptedFiles.find("/home/important/compilation/some_output_filename");
26412641
ASSERT_NE(mockOfflineCompiler.uniqueHelper->interceptedFiles.end(), outputFileIt);
26422642

26432643
EXPECT_EQ("12345678", outputFileIt->second);

shared/offline_compiler/source/offline_compiler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1178,7 +1178,7 @@ void OfflineCompiler::writeOutAllFiles() {
11781178
if (!elfBinary.empty()) {
11791179
std::string elfOutputFile;
11801180
if (outputNoSuffix) {
1181-
elfOutputFile = generateFilePath(outputDirectory, fileBase, ".bin");
1181+
elfOutputFile = generateFilePath(outputDirectory, fileBase, "");
11821182
} else {
11831183
elfOutputFile = generateFilePath(outputDirectory, fileBase, ".bin") + generateOptsSuffix();
11841184
}

0 commit comments

Comments
 (0)