Skip to content

Commit 847b850

Browse files
committed
Return status from Drm::queryVmId
Change-Id: Iec886c91de2920904bc3bec8e8811afd355b8738 Signed-off-by: Lukasz Jobczyk <[email protected]>
1 parent a779e44 commit 847b850

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

shared/source/os_interface/linux/drm_neo.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,19 +243,16 @@ void Drm::destroyDrmVirtualMemory(uint32_t drmVmId) {
243243
UNRECOVERABLE_IF(ret != 0);
244244
}
245245

246-
uint32_t Drm::queryVmId(uint32_t drmContextId) {
246+
int Drm::queryVmId(uint32_t drmContextId, uint32_t &vmId) {
247247
drm_i915_gem_context_param param{};
248248
param.ctx_id = drmContextId;
249249
param.value = 0;
250250
param.param = I915_CONTEXT_PARAM_VM;
251251
auto retVal = this->ioctl(DRM_IOCTL_I915_GEM_CONTEXT_GETPARAM, &param);
252-
DEBUG_BREAK_IF(retVal != 0);
253-
(void)retVal;
254252

255-
auto vmId = static_cast<uint32_t>(param.value);
256-
DEBUG_BREAK_IF(vmId == 0);
253+
vmId = static_cast<uint32_t>(param.value);
257254

258-
return vmId;
255+
return retVal;
259256
}
260257

261258
int Drm::getEuTotal(int &euTotal) {

shared/source/os_interface/linux/drm_neo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class Drm {
7272
void destroyDrmVirtualMemory(uint32_t drmVmId);
7373
uint32_t createDrmContext(uint32_t drmVmId);
7474
void destroyDrmContext(uint32_t drmContextId);
75-
uint32_t queryVmId(uint32_t drmContextId);
75+
int queryVmId(uint32_t drmContextId, uint32_t &vmId);
7676
void setLowPriorityContextParam(uint32_t drmContextId);
7777

7878
unsigned int bindDrmContext(uint32_t drmContextId, uint32_t deviceIndex, aub_stream::EngineType engineType);

shared/source/os_interface/linux/os_context_linux.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ OsContextLinux::OsContextLinux(Drm &drm, uint32_t contextId, DeviceBitfield devi
4343
this->drmContextIds.push_back(drmContextId);
4444

4545
if (drm.isPerContextVMRequired()) {
46-
drmVmId = drm.queryVmId(drmContextId);
46+
auto ret = drm.queryVmId(drmContextId, drmVmId);
47+
DEBUG_BREAK_IF(drmVmId == 0);
48+
DEBUG_BREAK_IF(ret != 0);
49+
UNUSED_VARIABLE(ret);
4750
this->drmVmIds.push_back(drmVmId);
4851
}
4952
}

0 commit comments

Comments
 (0)