Skip to content

Commit 907dec5

Browse files
Dont defer BCS context initialization
Signed-off-by: Mateusz Jablonski <[email protected]>
1 parent 8d0e203 commit 907dec5

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

opencl/test/unit_test/command_queue/command_queue_tests.cpp

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1645,20 +1645,3 @@ HWTEST_F(CommandQueueOnSpecificEngineTests, givenNotInitializedCcsOsContextWhenC
16451645
ASSERT_EQ(&osContext, queue.gpgpuEngine->osContext);
16461646
EXPECT_TRUE(osContext.isInitialized());
16471647
}
1648-
1649-
HWTEST_F(CommandQueueOnSpecificEngineTests, givenNotInitializedBcsOsContextWhenCreatingQueueThenInitializeOsContext) {
1650-
DebugManagerStateRestore restore{};
1651-
DebugManager.flags.DeferOsContextInitialization.set(1);
1652-
1653-
auto raiiHwHelper = overrideHwHelper<FamilyType, MockHwHelper<FamilyType, 1, 1, 1>>();
1654-
MockContext context{};
1655-
cl_command_queue_properties properties[5] = {};
1656-
1657-
OsContext &osContext = *context.getDevice(0)->getEngine(aub_stream::ENGINE_BCS, EngineUsage::Regular).osContext;
1658-
EXPECT_FALSE(osContext.isInitialized());
1659-
1660-
fillProperties(properties, 2, 0);
1661-
MockCommandQueueHw<FamilyType> queue(&context, context.getDevice(0), properties);
1662-
ASSERT_EQ(&osContext, queue.bcsEngine->osContext);
1663-
EXPECT_TRUE(osContext.isInitialized());
1664-
}

opencl/test/unit_test/os_interface/os_context_tests.cpp

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ struct DeferredOsContextCreationTests : ::testing::Test {
8181
std::unique_ptr<MockDevice> device;
8282
static inline const EngineTypeUsage engineTypeUsageRegular{aub_stream::ENGINE_RCS, EngineUsage::Regular};
8383
static inline const EngineTypeUsage engineTypeUsageInternal{aub_stream::ENGINE_RCS, EngineUsage::Internal};
84+
static inline const EngineTypeUsage engineTypeUsageBlitter{aub_stream::ENGINE_BCS, EngineUsage::Regular};
8485
};
8586

8687
TEST_F(DeferredOsContextCreationTests, givenRegularEngineWhenCreatingOsContextThenOsContextIsInitializedDeferred) {
@@ -119,6 +120,18 @@ TEST_F(DeferredOsContextCreationTests, givenInternalEngineWhenCreatingOsContextT
119120
expectImmediateContextCreation(engineTypeUsageInternal, false);
120121
}
121122

123+
TEST_F(DeferredOsContextCreationTests, givenBlitterEngineWhenCreatingOsContextThenOsContextIsInitializedImmediately) {
124+
DebugManagerStateRestore restore{};
125+
126+
expectImmediateContextCreation(engineTypeUsageBlitter, false);
127+
128+
DebugManager.flags.DeferOsContextInitialization.set(1);
129+
expectImmediateContextCreation(engineTypeUsageBlitter, false);
130+
131+
DebugManager.flags.DeferOsContextInitialization.set(0);
132+
expectImmediateContextCreation(engineTypeUsageBlitter, false);
133+
}
134+
122135
TEST_F(DeferredOsContextCreationTests, givenEnsureContextInitializeCalledMultipleTimesWhenOsContextIsCreatedThenInitializeOnlyOnce) {
123136
struct MyOsContext : OsContext {
124137
MyOsContext(uint32_t contextId,

shared/source/os_interface/os_context.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ bool OsContext::isImmediateContextInitializationEnabled(bool isDefaultEngine) co
3535
return true;
3636
}
3737

38+
if (engineType == aub_stream::EngineType::ENGINE_BCS) {
39+
return true;
40+
}
41+
3842
return false;
3943
}
4044

0 commit comments

Comments
 (0)