feature: Add support for querying pitched_alloc_2dimage_linear_pitch_exp_info_t

ola2308 · Compute-Runtime-Automation · commit 9dcb1b6252a8 · 2025-11-19T14:43:27.000+01:00
Add support for reporting pitchAlign and maxSupportedPitch for 2D linear
pitched allocations. This change addresses missing device properties
required for SYCL bindless image E2E tests. And removed unused
ze_bindless_image_exp.h file.

Resolves: NEO-16433
Signed-off-by: Aleksandra Nizio &lt;aleksandra.nizio@intel.com&gt;
diff --git a/level_zero/api/extensions/public/ze_exp_ext.h b/level_zero/api/extensions/public/ze_exp_ext.h
@@ -7,7 +7,6 @@
 
 #pragma once
 
-#include "level_zero/driver_experimental/ze_bindless_image_exp.h"
 #include <level_zero/ze_api.h>
 #include <level_zero/zet_api.h>
 
diff --git a/level_zero/core/source/device/device_imp.cpp b/level_zero/core/source/device/device_imp.cpp
@@ -1333,9 +1333,13 @@ ze_result_t DeviceImp::getDeviceImageProperties(ze_device_image_properties_t *pD
         ze_base_properties_t *extendedProperties = reinterpret_cast<ze_base_properties_t *>(pDeviceImageProperties->pNext);
         while (extendedProperties) {
             if (extendedProperties->stype == ZE_STRUCTURE_TYPE_PITCHED_ALLOC_DEVICE_EXP_PROPERTIES) {
-                ze_device_pitched_alloc_exp_properties_t *properties = reinterpret_cast<ze_device_pitched_alloc_exp_properties_t *>(extendedProperties);
+                auto *properties = reinterpret_cast<ze_device_pitched_alloc_exp_properties_t *>(extendedProperties);
                 properties->maxImageLinearHeight = deviceInfo.image2DMaxHeight;
                 properties->maxImageLinearWidth = deviceInfo.image2DMaxWidth;
+            } else if (extendedProperties->stype == ZE_STRUCTURE_TYPE_PITCHED_ALLOC_2DIMAGE_LINEAR_PITCH_EXP_INFO) {
+                auto *pitchInfo = reinterpret_cast<ze_pitched_alloc_2dimage_linear_pitch_exp_info_t *>(extendedProperties);
+                pitchInfo->pitchAlign = 64u;
+                pitchInfo->maxSupportedPitch = 256u * 1024u;
             }
             extendedProperties = reinterpret_cast<ze_base_properties_t *>(extendedProperties->pNext);
         }
diff --git a/level_zero/core/source/helpers/properties_parser.h b/level_zero/core/source/helpers/properties_parser.h
@@ -10,7 +10,6 @@
 #include "shared/source/helpers/common_types.h"
 #include "shared/source/helpers/surface_format_info.h"
 
-#include "level_zero/driver_experimental/ze_bindless_image_exp.h"
 #include "level_zero/driver_experimental/zex_common.h"
 #include "level_zero/include/level_zero/ze_intel_gpu.h"
 #include "level_zero/include/level_zero/ze_stypes.h"
diff --git a/level_zero/core/test/unit_tests/sources/device/test_l0_device.cpp b/level_zero/core/test/unit_tests/sources/device/test_l0_device.cpp
@@ -660,6 +660,60 @@ TEST(L0DeviceTest, givenSingleSliceTopologyWhenConvertingToPhysicalIdsThenSubsli
     EXPECT_TRUE(ret);
 }
 
+TEST(L0DeviceTest, givenPitchedAllocAndNestedPitchInfoStructuresWhenQueryingDeviceImagePropertiesThenValuesAreSetCorrectly) {
+    std::unique_ptr<DriverHandleImp> driverHandle(new DriverHandleImp);
+    auto hwInfo = *NEO::defaultHwInfo;
+    hwInfo.capabilityTable.supportsImages = true;
+    auto neoDevice = std::unique_ptr<NEO::Device>(
+        NEO::MockDevice::createWithNewExecutionEnvironment<NEO::MockDevice>(&hwInfo, 0));
+    auto device = std::unique_ptr<L0::Device>(
+        Device::create(driverHandle.get(), neoDevice.release(), false, nullptr));
+    ASSERT_NE(nullptr, device);
+
+    ze_device_image_properties_t imgProps = {};
+    imgProps.stype = ZE_STRUCTURE_TYPE_DEVICE_IMAGE_PROPERTIES;
+
+    ze_device_pitched_alloc_exp_properties_t pitchedProps = {};
+    pitchedProps.stype = ZE_STRUCTURE_TYPE_PITCHED_ALLOC_DEVICE_EXP_PROPERTIES;
+
+    ze_pitched_alloc_2dimage_linear_pitch_exp_info_t pitchInfo = {};
+    pitchInfo.stype = static_cast<ze_structure_type_t>(ZE_STRUCTURE_TYPE_PITCHED_ALLOC_2DIMAGE_LINEAR_PITCH_EXP_INFO);
+
+    imgProps.pNext = &pitchedProps;
+    pitchedProps.pNext = &pitchInfo;
+
+    auto result = device->getDeviceImageProperties(&imgProps);
+    EXPECT_EQ(ZE_RESULT_SUCCESS, result);
+
+    EXPECT_EQ(64u, pitchInfo.pitchAlign);
+    EXPECT_EQ(256u * 1024u, pitchInfo.maxSupportedPitch);
+}
+
+TEST(L0DeviceTest, givenPitchedAllocLinearPitchInfoStructWhenQueryingDeviceImagePropertiesThenCorrectValuesAreReturned) {
+    std::unique_ptr<DriverHandleImp> driverHandle(new DriverHandleImp);
+    auto hwInfo = *NEO::defaultHwInfo;
+    hwInfo.capabilityTable.supportsImages = true;
+    auto neoDevice = std::unique_ptr<NEO::Device>(
+        NEO::MockDevice::createWithNewExecutionEnvironment<NEO::MockDevice>(&hwInfo, 0));
+    auto device = std::unique_ptr<L0::Device>(
+        Device::create(driverHandle.get(), neoDevice.release(), false, nullptr));
+    ASSERT_NE(nullptr, device);
+
+    ze_device_image_properties_t imgProps = {};
+    imgProps.stype = ZE_STRUCTURE_TYPE_DEVICE_IMAGE_PROPERTIES;
+
+    ze_pitched_alloc_2dimage_linear_pitch_exp_info_t pitchInfo = {};
+    pitchInfo.stype = static_cast<ze_structure_type_t>(ZE_STRUCTURE_TYPE_PITCHED_ALLOC_2DIMAGE_LINEAR_PITCH_EXP_INFO);
+
+    imgProps.pNext = &pitchInfo;
+
+    auto result = device->getDeviceImageProperties(&imgProps);
+    EXPECT_EQ(ZE_RESULT_SUCCESS, result);
+
+    EXPECT_EQ(64u, pitchInfo.pitchAlign);
+    EXPECT_EQ(256u * 1024u, pitchInfo.maxSupportedPitch);
+}
+
 struct DeviceTest : public ::testing::Test {
     void SetUp() override {
         debugManager.flags.CreateMultipleRootDevices.set(numRootDevices);
diff --git a/level_zero/include/level_zero/driver_experimental/CMakeLists.txt b/level_zero/include/level_zero/driver_experimental/CMakeLists.txt
@@ -5,7 +5,6 @@
 #
 
 set(L0_API_DRIVER_EXPERIMENTAL_INCLUDE_FILES
-    ${CMAKE_CURRENT_SOURCE_DIR}/ze_bindless_image_exp.h
     ${CMAKE_CURRENT_SOURCE_DIR}/zex_api.h
     ${CMAKE_CURRENT_SOURCE_DIR}/zex_cmdlist.h
     ${CMAKE_CURRENT_SOURCE_DIR}/zex_common.h
diff --git a/level_zero/include/level_zero/driver_experimental/ze_bindless_image_exp.h b/level_zero/include/level_zero/driver_experimental/ze_bindless_image_exp.h
diff --git a/scripts/packaging/l0_gpu_driver/sles_15/SPECS/l0_gpu_driver.spec b/scripts/packaging/l0_gpu_driver/sles_15/SPECS/l0_gpu_driver.spec
@@ -127,7 +127,6 @@ fi
 %{_includedir}/level_zero/ze_intel_gpu.h
 %{_includedir}/level_zero/ze_intel_results.h
 %{_includedir}/level_zero/ze_stypes.h
-%{_includedir}/level_zero/driver_experimental/ze_bindless_image_exp.h
 %{_includedir}/level_zero/driver_experimental/zex_api.h
 %{_includedir}/level_zero/driver_experimental/zex_cmdlist.h
 %{_includedir}/level_zero/driver_experimental/zex_context.h
diff --git a/scripts/packaging/l0_gpu_driver/ubuntu_20.04/debian/intel-level-zero-gpu-devel.install b/scripts/packaging/l0_gpu_driver/ubuntu_20.04/debian/intel-level-zero-gpu-devel.install
@@ -2,7 +2,6 @@ usr/include/level_zero/zet_intel_gpu_debug.h
 usr/include/level_zero/ze_intel_gpu.h
 usr/include/level_zero/ze_intel_results.h
 usr/include/level_zero/ze_stypes.h
-usr/include/level_zero/driver_experimental/ze_bindless_image_exp.h
 usr/include/level_zero/driver_experimental/zex_api.h
 usr/include/level_zero/driver_experimental/zex_cmdlist.h
 usr/include/level_zero/driver_experimental/zex_context.h
diff --git a/scripts/packaging/ubuntu/debian/libze-intel-gpu-dev.install b/scripts/packaging/ubuntu/debian/libze-intel-gpu-dev.install
@@ -2,7 +2,6 @@ usr/include/level_zero/zet_intel_gpu_debug.h
 usr/include/level_zero/ze_intel_gpu.h
 usr/include/level_zero/ze_intel_results.h
 usr/include/level_zero/ze_stypes.h
-usr/include/level_zero/driver_experimental/ze_bindless_image_exp.h
 usr/include/level_zero/driver_experimental/zex_api.h
 usr/include/level_zero/driver_experimental/zex_cmdlist.h
 usr/include/level_zero/driver_experimental/zex_context.h

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@`
`5`	`5`	`#`
`6`	`6`
`7`	`7`	`set(L0_API_DRIVER_EXPERIMENTAL_INCLUDE_FILES`
`8`		`- ${CMAKE_CURRENT_SOURCE_DIR}/ze_bindless_image_exp.h`
`9`	`8`	`${CMAKE_CURRENT_SOURCE_DIR}/zex_api.h`
`10`	`9`	`${CMAKE_CURRENT_SOURCE_DIR}/zex_cmdlist.h`
`11`	`10`	`${CMAKE_CURRENT_SOURCE_DIR}/zex_common.h`