Change subDeviceIndex to subDevicesBitfield in allocation properties

Related-To: NEO-3691
Change-Id: I11d235107bf9b4cee75b910c114795b5df76d9c7
Signed-off-by: Mateusz Jablonski <[email protected]>

Author: JablonskiMateusz

core/command_container/cmdcontainer.cpp

@@ -47,11 +47,13 @@ bool CommandContainer::initialize(Device *device) {
     heapHelper = std::unique_ptr<HeapHelper>(new HeapHelper(device->getMemoryManager(), device->getDefaultEngine().commandStreamReceiver->getInternalAllocationStorage(), device->getNumAvailableDevices() > 1u));
 
     size_t alignedSize = alignUp<size_t>(totalCmdBufferSize, MemoryConstants::pageSize64k);
-    NEO::AllocationProperties properties{0u, true /* allocateMemory*/, alignedSize,
+    NEO::AllocationProperties properties{0u,
+                                         true /* allocateMemory*/,
+                                         alignedSize,
                                          GraphicsAllocation::AllocationType::INTERNAL_HOST_MEMORY,
                                          (device->getNumAvailableDevices() > 1u) /* multiOsContextCapable */,
                                          false,
-                                         NEO::SubDevice::unspecifiedSubDeviceIndex};
+                                         {}};
 
     cmdBufferAllocation = device->getMemoryManager()->allocateGraphicsMemoryWithProperties(properties);
 

core/helpers/heap_helper.cpp

@@ -17,15 +17,17 @@ GraphicsAllocation *HeapHelper::getHeapAllocation(size_t heapSize, size_t alignm
     if (allocation) {
         return allocation.release();
     }
-    NEO::AllocationProperties properties{rootDeviceIndex, true /* allocateMemory*/, alignment,
+    NEO::AllocationProperties properties{rootDeviceIndex,
+                                         true /* allocateMemory*/,
+                                         alignment,
                                          GraphicsAllocation::AllocationType::INTERNAL_HEAP,
-                                         isMultiOsContextCapable /* multiOsContextCapable */,
-                                         false,
-                                         NEO::SubDevice::unspecifiedSubDeviceIndex};
+                                         isMultiOsContextCapable,
+                                         false /* isMultiStorageAllocation */,
+                                         {}};
 
     return this->memManager->allocateGraphicsMemoryWithProperties(properties);
 }
 void HeapHelper::storeHeapAllocation(GraphicsAllocation *heapAllocation) {
     this->storageForReuse->storeAllocation(std::unique_ptr<NEO::GraphicsAllocation>(heapAllocation), NEO::AllocationUsage::REUSABLE_ALLOCATION);
 }
-} // namespace NEO
+} // namespace NEO

core/program/sync_buffer_handler.cpp

@@ -43,7 +43,7 @@ void SyncBufferHandler::prepareForEnqueue(size_t workGroupsCount, Kernel &kernel
 void SyncBufferHandler::allocateNewBuffer() {
     AllocationProperties allocationProperties{device.getRootDeviceIndex(), true, bufferSize,
                                               GraphicsAllocation::AllocationType::LINEAR_STREAM,
-                                              false, false, static_cast<uint32_t>(device.getDeviceBitfield().to_ulong())};
+                                              false, false, device.getDeviceBitfield()};
     graphicsAllocation = memoryManager.allocateGraphicsMemoryWithProperties(allocationProperties);
     UNRECOVERABLE_IF(graphicsAllocation == nullptr);
 

runtime/command_stream/command_stream_receiver.cpp

@@ -126,7 +126,7 @@ void CommandStreamReceiver::ensureCommandBufferAllocation(LinearStream &commandS
     auto allocation = this->getInternalAllocationStorage()->obtainReusableAllocation(allocationSize, allocationType).release();
     if (allocation == nullptr) {
         const AllocationProperties commandStreamAllocationProperties{rootDeviceIndex, true, allocationSize, allocationType,
-                                                                     isMultiOsContextCapable(), false, getDeviceIndex()};
+                                                                     isMultiOsContextCapable(), false, osContext->getDeviceBitfield()};
         allocation = this->getMemoryManager()->allocateGraphicsMemoryWithProperties(commandStreamAllocationProperties);
     }
     DEBUG_BREAK_IF(allocation == nullptr);
@@ -327,7 +327,7 @@ void CommandStreamReceiver::allocateHeapMemory(IndirectHeap::Type heapType,
 
     if (!heapMemory) {
         heapMemory = getMemoryManager()->allocateGraphicsMemoryWithProperties({rootDeviceIndex, true, finalHeapSize, allocationType,
-                                                                               isMultiOsContextCapable(), false, getDeviceIndex()});
+                                                                               isMultiOsContextCapable(), false, osContext->getDeviceBitfield()});
     } else {
         finalHeapSize = std::max(heapMemory->getUnderlyingBufferSize(), finalHeapSize);
     }

runtime/memory_manager/allocation_properties.h

@@ -32,7 +32,7 @@ struct AllocationProperties {
     GraphicsAllocation::AllocationType allocationType = GraphicsAllocation::AllocationType::UNKNOWN;
     ImageInfo *imgInfo = nullptr;
     bool multiStorageResource = false;
-    uint32_t subDeviceIndex = SubDevice::unspecifiedSubDeviceIndex;
+    DeviceBitfield subDevicesBitfield{};
 
     AllocationProperties(uint32_t rootDeviceIndex, size_t size,
                          GraphicsAllocation::AllocationType allocationType)
@@ -50,16 +50,20 @@ struct AllocationProperties {
                          size_t size,
                          GraphicsAllocation::AllocationType allocationType,
                          bool isMultiStorageAllocation)
-        : AllocationProperties(rootDeviceIndex, allocateMemory, size, allocationType, false, isMultiStorageAllocation, SubDevice::unspecifiedSubDeviceIndex) {}
+        : AllocationProperties(rootDeviceIndex, allocateMemory, size, allocationType, false, isMultiStorageAllocation, {}) {}
 
     AllocationProperties(uint32_t rootDeviceIndexParam,
                          bool allocateMemoryParam,
                          size_t sizeParam,
                          GraphicsAllocation::AllocationType allocationTypeParam,
                          bool multiOsContextCapableParam,
                          bool isMultiStorageAllocationParam,
-                         uint32_t subDeviceIndexParam)
-        : rootDeviceIndex(rootDeviceIndexParam), size(sizeParam), allocationType(allocationTypeParam), multiStorageResource(isMultiStorageAllocationParam), subDeviceIndex(subDeviceIndexParam) {
+                         DeviceBitfield subDevicesBitfieldParam)
+        : rootDeviceIndex(rootDeviceIndexParam),
+          size(sizeParam),
+          allocationType(allocationTypeParam),
+          multiStorageResource(isMultiStorageAllocationParam),
+          subDevicesBitfield(subDevicesBitfieldParam) {
         allFlags = 0;
         flags.flushL3RequiredForRead = 1;
         flags.flushL3RequiredForWrite = 1;

unit_tests/memory_manager/memory_manager_tests.cpp

@@ -878,7 +878,7 @@ TEST(OsAgnosticMemoryManager, givenDefaultMemoryManagerWhenCreateGraphicsAllocat
     osHandle handle = 1;
     auto size = 4096u;
     AllocationProperties properties(0u, false, size, GraphicsAllocation::AllocationType::SHARED_BUFFER, false, false, 0u);
-    EXPECT_EQ(properties.subDeviceIndex, 0u);
+    EXPECT_TRUE(properties.subDevicesBitfield.none());
     EXPECT_EQ(properties.rootDeviceIndex, 0u);
 
     auto sharedAllocation = memoryManager.createGraphicsAllocationFromSharedHandle(handle, properties, false);

unit_tests/os_interface/linux/drm_memory_manager_tests.cpp

@@ -1557,7 +1557,7 @@ TEST_F(DrmMemoryManagerTest, givenDrmMemoryManagerAndOsHandleWhenCreateIsCalledA
     this->mock->outputHandle = 2u;
     size_t size = 4096u;
     AllocationProperties properties(0u, false, size, GraphicsAllocation::AllocationType::SHARED_BUFFER, false, false, 0u);
-    ASSERT_EQ(properties.subDeviceIndex, 0u);
+    ASSERT_TRUE(properties.subDevicesBitfield.none());
     ASSERT_EQ(properties.rootDeviceIndex, 0u);
 
     auto graphicsAllocation = memoryManager->createGraphicsAllocationFromSharedHandle(handle, properties, false);