Skip to content

Commit c031bf5

Browse files
ULT renaming: Kernel Arg Info tests
Related-To: NEO-2236 Change-Id: Ice8dd25f032f5a1d10c4b1be2019516d5f217586 Signed-off-by: Adam Cetnerowski <[email protected]>
1 parent ac3968f commit c031bf5

File tree

1 file changed

+30
-34
lines changed

1 file changed

+30
-34
lines changed

opencl/test/unit_test/kernel/kernel_arg_info_tests.cpp

Lines changed: 30 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,7 @@ class KernelArgInfoTest : public ProgramFromSourceTest {
9090
KernelBinaryHelper *kbHelper = nullptr;
9191
};
9292

93-
TEST_P(KernelArgInfoTest, Create_Simple) {
94-
// included in the setup of fixture
95-
}
96-
97-
TEST_P(KernelArgInfoTest, WhenQueryingWithNullptrKernelNameTheniReturnNullptr) {
93+
TEST_P(KernelArgInfoTest, GivenNullWhenGettingKernelInfoThenNullIsReturned) {
9894
auto kernelInfo = this->pProgram->getKernelInfo(nullptr);
9995
EXPECT_EQ(nullptr, kernelInfo);
10096
}
@@ -112,90 +108,90 @@ TEST_P(KernelArgInfoTest, GivenInvalidParametersWhenGettingKernelArgInfoThenValu
112108
EXPECT_EQ(0x1234u, paramValueSizeRet);
113109
}
114110

115-
TEST_P(KernelArgInfoTest, getKernelArgAcessQualifier) {
111+
TEST_P(KernelArgInfoTest, GivenKernelArgAccessQualifierWhenQueryingArgInfoThenKernelArgAcessNoneIsReturned) {
116112
cl_kernel_arg_access_qualifier param_value = 0;
117113
queryArgInfo<cl_kernel_arg_access_qualifier>(CL_KERNEL_ARG_ACCESS_QUALIFIER, param_value);
118114
EXPECT_EQ(static_cast<cl_kernel_arg_access_qualifier>(CL_KERNEL_ARG_ACCESS_NONE), param_value);
119115
}
120116

121-
TEST_P(KernelArgInfoTest, getKernelAddressQulifier) {
117+
TEST_P(KernelArgInfoTest, GivenKernelArgAddressQualifierWhenQueryingArgInfoThenKernelArgAddressGlobalIsReturned) {
122118
cl_kernel_arg_address_qualifier param_value = 0;
123119
queryArgInfo<cl_kernel_arg_address_qualifier>(CL_KERNEL_ARG_ADDRESS_QUALIFIER, param_value);
124120
EXPECT_EQ(static_cast<cl_kernel_arg_address_qualifier>(CL_KERNEL_ARG_ADDRESS_GLOBAL), param_value);
125121
}
126122

127-
TEST_P(KernelArgInfoTest, getKernelTypeQualifer) {
123+
TEST_P(KernelArgInfoTest, GivenKernelArgTypeQualifierWhenQueryingArgInfoThenKernelArgTypeNoneIsReturned) {
128124
cl_kernel_arg_type_qualifier param_value = 0;
129125
queryArgInfo<cl_kernel_arg_type_qualifier>(CL_KERNEL_ARG_TYPE_QUALIFIER, param_value);
130126
EXPECT_EQ(static_cast<cl_kernel_arg_type_qualifier>(CL_KERNEL_ARG_TYPE_NONE), param_value);
131127
}
132128

133-
TEST_P(KernelArgInfoTest, getKernelTypeName) {
134-
cl_kernel_arg_info param_name = CL_KERNEL_ARG_TYPE_NAME;
135-
char *param_value = nullptr;
129+
TEST_P(KernelArgInfoTest, GivenParamWhenGettingKernelTypeNameThenCorrectValueIsReturned) {
130+
cl_kernel_arg_info paramName = CL_KERNEL_ARG_TYPE_NAME;
131+
char *paramValue = nullptr;
136132
size_t paramValueSize = 0;
137-
size_t param_value_size_ret = 0;
133+
size_t paramValueSizeRet = 0;
138134

139135
// get size
140136
retVal = pKernel->getArgInfo(
141137
0,
142-
param_name,
138+
paramName,
143139
paramValueSize,
144140
nullptr,
145-
&param_value_size_ret);
146-
EXPECT_NE(0u, param_value_size_ret);
141+
&paramValueSizeRet);
142+
EXPECT_NE(0u, paramValueSizeRet);
147143
ASSERT_EQ(CL_SUCCESS, retVal);
148144

149145
// allocate space for name
150-
param_value = new char[param_value_size_ret];
146+
paramValue = new char[paramValueSizeRet];
151147

152148
// get the name
153-
paramValueSize = param_value_size_ret;
149+
paramValueSize = paramValueSizeRet;
154150

155151
retVal = pKernel->getArgInfo(
156152
0,
157-
param_name,
153+
paramName,
158154
paramValueSize,
159-
param_value,
155+
paramValue,
160156
nullptr);
161157
ASSERT_EQ(CL_SUCCESS, retVal);
162158
const char expectedString[] = "uint*";
163-
auto result = strncmp(param_value, expectedString, sizeof(expectedString));
159+
auto result = strncmp(paramValue, expectedString, sizeof(expectedString));
164160
EXPECT_EQ(0, result);
165-
delete[] param_value;
161+
delete[] paramValue;
166162
}
167163

168-
TEST_P(KernelArgInfoTest, getKernelArgName) {
169-
cl_kernel_arg_info param_name = CL_KERNEL_ARG_NAME;
170-
char *param_value = nullptr;
164+
TEST_P(KernelArgInfoTest, GivenParamWhenGettingKernelArgNameThenCorrectValueIsReturned) {
165+
cl_kernel_arg_info paramName = CL_KERNEL_ARG_NAME;
166+
char *paramValue = nullptr;
171167
size_t paramValueSize = 0;
172-
size_t param_value_size_ret = 0;
168+
size_t paramValueSizeRet = 0;
173169

174170
// get size
175171
retVal = pKernel->getArgInfo(
176172
0,
177-
param_name,
173+
paramName,
178174
paramValueSize,
179175
nullptr,
180-
&param_value_size_ret);
181-
EXPECT_NE(0u, param_value_size_ret);
176+
&paramValueSizeRet);
177+
EXPECT_NE(0u, paramValueSizeRet);
182178
ASSERT_EQ(CL_SUCCESS, retVal);
183179

184180
// allocate space for name
185-
param_value = new char[param_value_size_ret];
181+
paramValue = new char[paramValueSizeRet];
186182

187183
// get the name
188-
paramValueSize = param_value_size_ret;
184+
paramValueSize = paramValueSizeRet;
189185

190186
retVal = pKernel->getArgInfo(
191187
0,
192-
param_name,
188+
paramName,
193189
paramValueSize,
194-
param_value,
190+
paramValue,
195191
nullptr);
196192
ASSERT_EQ(CL_SUCCESS, retVal);
197-
EXPECT_EQ(0, strcmp(param_value, "src"));
198-
delete[] param_value;
193+
EXPECT_EQ(0, strcmp(paramValue, "src"));
194+
delete[] paramValue;
199195
}
200196

201197
INSTANTIATE_TEST_CASE_P(KernelArgInfoTests,

0 commit comments

Comments
 (0)