Skip to content

Commit c90f3b3

Browse files
JablonskiMateuszCompute-Runtime-Automation
JablonskiMateusz
authored and
Compute-Runtime-Automation
committed
Correct naming: SetUpImpl -> setUpImpl
Signed-off-by: Mateusz Jablonski <[email protected]>
1 parent 6550dca commit c90f3b3

24 files changed

+86
-86
lines changed

‎opencl/test/unit_test/aub_tests/fixtures/image_aub_fixture.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ struct ImageAubFixture : public ClDeviceFixture, public AUBCommandStreamFixture
3535

3636
hardwareInfo = *defaultHwInfo;
3737
hardwareInfo.capabilityTable.blitterOperationsSupported = true;
38-
ClDeviceFixture::SetUpImpl(&hardwareInfo);
38+
ClDeviceFixture::setUpImpl(&hardwareInfo);
3939
} else {
4040
ClDeviceFixture::SetUp();
4141
}

‎opencl/test/unit_test/command_queue/command_queue_fixture.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ struct CommandQueueHwBlitTest : ClDeviceFixture, ContextFixture, CommandQueueHwF
9898
DebugManager.flags.EnableBlitterOperationsSupport.set(1);
9999
DebugManager.flags.EnableTimestampPacket.set(1);
100100
DebugManager.flags.PreferCopyEngineForCopyBufferToBuffer.set(1);
101-
ClDeviceFixture::SetUpImpl(&hwInfo);
101+
ClDeviceFixture::setUpImpl(&hwInfo);
102102
cl_device_id device = pClDevice;
103103
ContextFixture::SetUp(1, &device);
104104
cl_command_queue_properties queueProperties = ooq ? CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE : 0;

‎opencl/test/unit_test/command_queue/command_queue_hw_2_tests.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ struct MockBuilder : BuiltinDispatchInfoBuilder {
6868

6969
struct BuiltinParamsCommandQueueHwTests : public CommandQueueHwTest {
7070

71-
void SetUpImpl(EBuiltInOps::Type operation) {
71+
void setUpImpl(EBuiltInOps::Type operation) {
7272
auto builtIns = new MockBuiltins();
7373
pCmdQ->getDevice().getExecutionEnvironment()->rootDeviceEnvironments[pCmdQ->getDevice().getRootDeviceIndex()]->builtins.reset(builtIns);
7474

@@ -87,7 +87,7 @@ struct BuiltinParamsCommandQueueHwTests : public CommandQueueHwTest {
8787

8888
HWTEST_F(BuiltinParamsCommandQueueHwTests, givenEnqueueReadWriteBufferCallWhenBuiltinParamsArePassedThenCheckValuesCorectness) {
8989

90-
SetUpImpl(EBuiltInOps::CopyBufferToBuffer);
90+
setUpImpl(EBuiltInOps::CopyBufferToBuffer);
9191
BufferDefaults::context = context;
9292
auto buffer = clUniquePtr(BufferHelper<>::create());
9393

@@ -121,7 +121,7 @@ HWTEST_F(BuiltinParamsCommandQueueHwTests, givenEnqueueReadWriteBufferCallWhenBu
121121

122122
HWTEST_F(BuiltinParamsCommandQueueHwTests, givenEnqueueWriteImageCallWhenBuiltinParamsArePassedThenCheckValuesCorectness) {
123123

124-
SetUpImpl(EBuiltInOps::CopyBufferToImage3d);
124+
setUpImpl(EBuiltInOps::CopyBufferToImage3d);
125125

126126
std::unique_ptr<Image> dstImage(ImageHelper<ImageUseHostPtr<Image2dDefaults>>::create(context));
127127

@@ -162,7 +162,7 @@ HWTEST_F(BuiltinParamsCommandQueueHwTests, givenEnqueueWriteImageCallWhenBuiltin
162162

163163
HWTEST_F(BuiltinParamsCommandQueueHwTests, givenEnqueueReadImageCallWhenBuiltinParamsArePassedThenCheckValuesCorectness) {
164164

165-
SetUpImpl(EBuiltInOps::CopyImage3dToBuffer);
165+
setUpImpl(EBuiltInOps::CopyImage3dToBuffer);
166166

167167
std::unique_ptr<Image> dstImage(ImageHelper<ImageUseHostPtr<Image2dDefaults>>::create(context));
168168

@@ -203,7 +203,7 @@ HWTEST_F(BuiltinParamsCommandQueueHwTests, givenEnqueueReadImageCallWhenBuiltinP
203203

204204
HWTEST_F(BuiltinParamsCommandQueueHwTests, givenEnqueueReadWriteBufferRectCallWhenBuiltinParamsArePassedThenCheckValuesCorectness) {
205205

206-
SetUpImpl(EBuiltInOps::CopyBufferRect);
206+
setUpImpl(EBuiltInOps::CopyBufferRect);
207207

208208
BufferDefaults::context = context;
209209
auto buffer = clUniquePtr(BufferHelper<>::create());

‎opencl/test/unit_test/command_queue/command_queue_tests.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2405,7 +2405,7 @@ TEST_F(CommandQueueWithTimestampPacketTests, givenQueueWhenSettingAndQueryingLas
24052405
using KernelExecutionTypesTests = DispatchFlagsTests;
24062406
HWTEST_F(KernelExecutionTypesTests, givenConcurrentKernelWhileDoingNonBlockedEnqueueThenCorrectKernelTypeIsSetInCSR) {
24072407
using CsrType = MockCsrHw2<FamilyType>;
2408-
SetUpImpl<CsrType>();
2408+
setUpImpl<CsrType>();
24092409
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
24102410
MockKernelWithInternals mockKernelWithInternals(*device.get());
24112411
auto pKernel = mockKernelWithInternals.mockKernel;
@@ -2421,7 +2421,7 @@ HWTEST_F(KernelExecutionTypesTests, givenConcurrentKernelWhileDoingNonBlockedEnq
24212421

24222422
HWTEST_F(KernelExecutionTypesTests, givenKernelWithDifferentExecutionTypeWhileDoingNonBlockedEnqueueThenKernelTypeInCSRIsChanging) {
24232423
using CsrType = MockCsrHw2<FamilyType>;
2424-
SetUpImpl<CsrType>();
2424+
setUpImpl<CsrType>();
24252425
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
24262426
MockKernelWithInternals mockKernelWithInternals(*device.get());
24272427
auto pKernel = mockKernelWithInternals.mockKernel;
@@ -2443,7 +2443,7 @@ HWTEST_F(KernelExecutionTypesTests, givenKernelWithDifferentExecutionTypeWhileDo
24432443

24442444
HWTEST_F(KernelExecutionTypesTests, givenConcurrentKernelWhileDoingBlockedEnqueueThenCorrectKernelTypeIsSetInCSR) {
24452445
using CsrType = MockCsrHw2<FamilyType>;
2446-
SetUpImpl<CsrType>();
2446+
setUpImpl<CsrType>();
24472447
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
24482448
MockKernelWithInternals mockKernelWithInternals(*device.get());
24492449
auto pKernel = mockKernelWithInternals.mockKernel;

‎opencl/test/unit_test/command_queue/enqueue_command_without_kernel_tests.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ HWTEST_F(EnqueueHandlerTest, givenBlitPropertyWhenEnqueueIsBlockedThenRegisterBl
277277

278278
HWTEST_F(DispatchFlagsTests, whenEnqueueCommandWithoutKernelThenPassCorrectDispatchFlags) {
279279
using CsrType = MockCsrHw2<FamilyType>;
280-
SetUpImpl<CsrType>();
280+
setUpImpl<CsrType>();
281281

282282
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
283283
auto mockCsr = static_cast<CsrType *>(&mockCmdQ->getGpgpuCommandStreamReceiver());
@@ -303,7 +303,7 @@ HWTEST_F(DispatchFlagsTests, whenEnqueueCommandWithoutKernelThenPassCorrectDispa
303303

304304
HWTEST_F(DispatchFlagsTests, whenEnqueueCommandWithoutKernelThenPassCorrectThrottleHint) {
305305
using CsrType = MockCsrHw2<FamilyType>;
306-
SetUpImpl<CsrType>();
306+
setUpImpl<CsrType>();
307307

308308
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
309309
mockCmdQ->throttle = QueueThrottle::HIGH;
@@ -328,7 +328,7 @@ HWTEST_F(DispatchFlagsBlitTests, givenBlitEnqueueWhenDispatchingCommandsWithoutK
328328
DebugManager.flags.ForceGpgpuSubmissionForBcsEnqueue.set(1);
329329
DebugManager.flags.EnableTimestampPacket.set(1);
330330

331-
SetUpImpl<CsrType>();
331+
setUpImpl<CsrType>();
332332
REQUIRE_FULL_BLITTER_OR_SKIP(&device->getHardwareInfo());
333333

334334
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
@@ -373,7 +373,7 @@ HWTEST_F(DispatchFlagsBlitTests, givenN1EnabledWhenDispatchingWithoutKernelThenA
373373
DebugManager.flags.EnableTimestampPacket.set(1);
374374
DebugManager.flags.ForceGpgpuSubmissionForBcsEnqueue.set(1);
375375

376-
SetUpImpl<CsrType>();
376+
setUpImpl<CsrType>();
377377
REQUIRE_FULL_BLITTER_OR_SKIP(&device->getHardwareInfo());
378378

379379
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
@@ -417,7 +417,7 @@ HWTEST_F(DispatchFlagsBlitTests, givenN1EnabledWhenDispatchingWithoutKernelThenA
417417

418418
HWTEST_F(DispatchFlagsTests, givenMockKernelWhenSettingAdditionalKernelExecInfoThenCorrectValueIsSet) {
419419
using CsrType = MockCsrHw2<FamilyType>;
420-
SetUpImpl<CsrType>();
420+
setUpImpl<CsrType>();
421421

422422
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
423423
auto mockCsr = static_cast<CsrType *>(&mockCmdQ->getGpgpuCommandStreamReceiver());

‎opencl/test/unit_test/command_queue/enqueue_command_without_kernel_tests_dg2_and_later.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ using IsDG2AndLater = IsAtLeastXeHpgCore;
2727

2828
HWTEST2_F(DispatchFlagsTests, whenSubmittingKernelWithAdditionalKernelExecInfoThenCorrectDispatchFlagIsSet, IsDG2AndLater) {
2929
using CsrType = MockCsrHw2<FamilyType>;
30-
SetUpImpl<CsrType>();
30+
setUpImpl<CsrType>();
3131

3232
auto mockCmdQ = std::make_unique<MockCommandQueueHw<FamilyType>>(context.get(), device.get(), nullptr);
3333
auto mockCsr = static_cast<CsrType *>(&mockCmdQ->getGpgpuCommandStreamReceiver());

‎opencl/test/unit_test/command_queue/sync_buffer_handler_tests.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class SyncBufferEnqueueHandlerTest : public EnqueueHandlerTest {
3434
hardwareInfo.capabilityTable.blitterOperationsSupported = true;
3535
uint64_t hwInfoConfig = defaultHardwareInfoConfigTable[productFamily];
3636
hardwareInfoSetup[productFamily](&hardwareInfo, true, hwInfoConfig);
37-
SetUpImpl(&hardwareInfo);
37+
setUpImpl(&hardwareInfo);
3838
}
3939

4040
void TearDown() override {
@@ -44,7 +44,7 @@ class SyncBufferEnqueueHandlerTest : public EnqueueHandlerTest {
4444
pDevice = nullptr;
4545
}
4646

47-
void SetUpImpl(const NEO::HardwareInfo *hardwareInfo) {
47+
void setUpImpl(const NEO::HardwareInfo *hardwareInfo) {
4848
pDevice = MockDevice::createWithNewExecutionEnvironment<MockDevice>(hardwareInfo);
4949
ASSERT_NE(nullptr, pDevice);
5050
pClDevice = new MockClDevice{pDevice};

‎opencl/test/unit_test/fixtures/cl_device_fixture.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2020-2021 Intel Corporation
2+
* Copyright (C) 2020-2022 Intel Corporation
33
*
44
* SPDX-License-Identifier: MIT
55
*
@@ -14,10 +14,10 @@
1414
namespace NEO {
1515
void ClDeviceFixture::SetUp() {
1616
hardwareInfo = *defaultHwInfo;
17-
SetUpImpl(&hardwareInfo);
17+
setUpImpl(&hardwareInfo);
1818
}
1919

20-
void ClDeviceFixture::SetUpImpl(const NEO::HardwareInfo *hardwareInfo) {
20+
void ClDeviceFixture::setUpImpl(const NEO::HardwareInfo *hardwareInfo) {
2121
pDevice = MockClDevice::createWithNewExecutionEnvironment<MockDevice>(hardwareInfo, rootDeviceIndex);
2222
ASSERT_NE(nullptr, pDevice);
2323
pClExecutionEnvironment = static_cast<MockClExecutionEnvironment *>(pDevice->getExecutionEnvironment());

‎opencl/test/unit_test/fixtures/cl_device_fixture.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ namespace NEO {
1414
struct HardwareInfo;
1515

1616
struct ClDeviceFixture {
17-
void SetUp(); // NOLINT(readability-identifier-naming)
18-
void SetUpImpl(const NEO::HardwareInfo *hardwareInfo); // NOLINT(readability-identifier-naming)
19-
void TearDown(); // NOLINT(readability-identifier-naming)
17+
void SetUp(); // NOLINT(readability-identifier-naming)
18+
void setUpImpl(const NEO::HardwareInfo *hardwareInfo);
19+
void TearDown(); // NOLINT(readability-identifier-naming)
2020

2121
MockDevice *createWithUsDeviceId(unsigned short usDeviceId);
2222

‎opencl/test/unit_test/fixtures/dispatch_flags_fixture.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ namespace NEO {
2020
template <bool setupBlitter>
2121
struct DispatchFlagsTestsBase : public ::testing::Test {
2222
template <typename CsrType>
23-
void SetUpImpl() { // NOLINT(readability-identifier-naming)
23+
void setUpImpl() {
2424
HardwareInfo hwInfo = *defaultHwInfo;
2525
if (setupBlitter) {
2626
hwInfo.capabilityTable.blitterOperationsSupported = true;

0 commit comments

Comments
 (0)