feat(zebin): set missing pointer size for arg type buffer address

km-nowak · Compute-Runtime-Automation · commit cc17c53a77a0 · 2022-08-18T20:37:24.000+02:00
Set missing pointer size for argument type buffer address in zebin.
This PR is related to test failures after merging corresponding IGC
change.

Related-To: IGC-5486
Signed-off-by: Kacper Nowak &lt;kacper.nowak@intel.com&gt;
diff --git a/shared/source/device_binary_format/zebin_decoder.cpp b/shared/source/device_binary_format/zebin_decoder.cpp
@@ -875,6 +875,7 @@ NEO::DecodeError populateArgDescriptor(const NEO::Elf::ZebinKernelMetadata::Type
         }
         auto &argAsPointer = dst.payloadMappings.explicitArgs[src.argIndex].as<ArgDescPointer>(true);
         argAsPointer.bufferOffset = src.offset;
+        argAsPointer.pointerSize = src.size;
         break;
     }
 
diff --git a/shared/test/unit_test/device_binary_format/zebin_decoder_tests.cpp b/shared/test/unit_test/device_binary_format/zebin_decoder_tests.cpp
@@ -4671,6 +4671,7 @@ TEST(PopulateArgDescriptorCrossthreadPayload, GivenArgTypeBufferOffsetWhenOffset
     ASSERT_EQ(1U, programInfo.kernelInfos[0]->kernelDescriptor.payloadMappings.explicitArgs.size());
     const auto &arg = programInfo.kernelInfos[0]->kernelDescriptor.payloadMappings.explicitArgs[0].as<ArgDescPointer>();
     EXPECT_EQ(8, arg.bufferOffset);
+    EXPECT_EQ(4, arg.pointerSize);
 }
 
 TEST(PopulateArgDescriptorCrossthreadPayload, givenPureStatefulArgWithBufferAddressWhenThereIsNoStatelessAccessThenPopulatesKernelDescriptorAndArgIsPureStateful) {

Original file line number	Diff line number	Diff line change
`@@ -875,6 +875,7 @@ NEO::DecodeError populateArgDescriptor(const NEO::Elf::ZebinKernelMetadata::Type`
`875`	`875`	`}`
`876`	`876`	`auto &argAsPointer = dst.payloadMappings.explicitArgs[src.argIndex].as<ArgDescPointer>(true);`
`877`	`877`	`argAsPointer.bufferOffset = src.offset;`
	`878`	`+ argAsPointer.pointerSize = src.size;`
`878`	`879`	`break;`
`879`	`880`	`}`
`880`	`881`
Original file line number	Diff line number	Diff line change
`@@ -4671,6 +4671,7 @@ TEST(PopulateArgDescriptorCrossthreadPayload, GivenArgTypeBufferOffsetWhenOffset`
`4671`	`4671`	`ASSERT_EQ(1U, programInfo.kernelInfos[0]->kernelDescriptor.payloadMappings.explicitArgs.size());`
`4672`	`4672`	`const auto &arg = programInfo.kernelInfos[0]->kernelDescriptor.payloadMappings.explicitArgs[0].as<ArgDescPointer>();`
`4673`	`4673`	`EXPECT_EQ(8, arg.bufferOffset);`
	`4674`	`+ EXPECT_EQ(4, arg.pointerSize);`
`4674`	`4675`	`}`
`4675`	`4676`
`4676`	`4677`	`TEST(PopulateArgDescriptorCrossthreadPayload, givenPureStatefulArgWithBufferAddressWhenThereIsNoStatelessAccessThenPopulatesKernelDescriptorAndArgIsPureStateful) {`