Skip to content

Commit d166683

Browse files
Stop using NOLINT for setup and teardown methods
Signed-off-by: Mateusz Jablonski <[email protected]>
1 parent ceb9d81 commit d166683

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

opencl/test/unit_test/built_ins/built_in_tests.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class BuiltInTests
5858
public ContextFixture,
5959
public ::testing::Test {
6060

61-
using BuiltInFixture::SetUp;
61+
using BuiltInFixture::setUp;
6262
using ContextFixture::setUp;
6363

6464
public:
@@ -73,12 +73,12 @@ class BuiltInTests
7373
ClDeviceFixture::setUp();
7474
cl_device_id device = pClDevice;
7575
ContextFixture::setUp(1, &device);
76-
BuiltInFixture::SetUp(pDevice);
76+
BuiltInFixture::setUp(pDevice);
7777
}
7878

7979
void TearDown() override {
8080
allBuiltIns.clear();
81-
BuiltInFixture::TearDown();
81+
BuiltInFixture::tearDown();
8282
ContextFixture::tearDown();
8383
ClDeviceFixture::tearDown();
8484
}

opencl/test/unit_test/fixtures/built_in_fixture.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2018-2021 Intel Corporation
2+
* Copyright (C) 2018-2022 Intel Corporation
33
*
44
* SPDX-License-Identifier: MIT
55
*
@@ -16,7 +16,7 @@
1616

1717
using namespace NEO;
1818

19-
void BuiltInFixture::SetUp(Device *pDevice) {
19+
void BuiltInFixture::setUp(Device *pDevice) {
2020
// create an instance of the builtins
2121
pBuiltIns = pDevice->getBuiltIns();
2222
pBuiltIns->setCacheingEnableState(false);
@@ -38,7 +38,7 @@ void BuiltInFixture::SetUp(Device *pDevice) {
3838
gEnvironment->igcPushDebugVars(igcDebugVars);
3939
}
4040

41-
void BuiltInFixture::TearDown() {
41+
void BuiltInFixture::tearDown() {
4242
gEnvironment->igcPopDebugVars();
4343
gEnvironment->fclPopDebugVars();
4444
}

opencl/test/unit_test/fixtures/built_in_fixture.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ class Device;
1414

1515
class BuiltInFixture {
1616
public:
17-
void SetUp(NEO::Device *pDevice); // NOLINT(readability-identifier-naming)
18-
void TearDown(); // NOLINT(readability-identifier-naming)
17+
void setUp(NEO::Device *pDevice);
18+
void tearDown();
1919

2020
NEO::BuiltIns *pBuiltIns = nullptr;
2121
};

opencl/test/unit_test/helpers/hardware_commands_helper_tests.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,15 +36,15 @@ void HardwareCommandsTest::SetUp() {
3636
cl_device_id device = pClDevice;
3737
ContextFixture::setUp(1, &device);
3838
ASSERT_NE(nullptr, pContext);
39-
BuiltInFixture::SetUp(pDevice);
39+
BuiltInFixture::setUp(pDevice);
4040
ASSERT_NE(nullptr, pBuiltIns);
4141

4242
mockKernelWithInternal = std::make_unique<MockKernelWithInternals>(*pClDevice, pContext);
4343
}
4444

4545
void HardwareCommandsTest::TearDown() {
4646
mockKernelWithInternal.reset(nullptr);
47-
BuiltInFixture::TearDown();
47+
BuiltInFixture::tearDown();
4848
ContextFixture::tearDown();
4949
ClDeviceFixture::tearDown();
5050
}

opencl/test/unit_test/helpers/hardware_commands_helper_tests.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ struct HardwareCommandsTest : ClDeviceFixture,
2929
BuiltInFixture,
3030
::testing::Test {
3131

32-
using BuiltInFixture::SetUp;
32+
using BuiltInFixture::setUp;
3333
using ContextFixture::setUp;
3434

3535
void SetUp() override;

0 commit comments

Comments
 (0)