Skip to content

Commit d1a9174

Browse files
Enable early pin on direct submission
Resolves: NEO-5112 Change-Id: I79398dda9de3584d327e9448dd57e9a3ed37b377 Signed-off-by: Lukasz Jobczyk <[email protected]>
1 parent a0531c1 commit d1a9174

File tree

4 files changed

+1
-17
lines changed

4 files changed

+1
-17
lines changed

opencl/test/unit_test/os_interface/linux/drm_memory_manager_tests.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2849,16 +2849,6 @@ TEST_F(DrmMemoryManagerBasic, givenDefaultMemoryManagerWhenItIsCreatedThenAsyncD
28492849
memoryManager.commonCleanup();
28502850
}
28512851

2852-
TEST_F(DrmMemoryManagerBasic, givenEnabledDirectSubmissionWhenMemoryManagerIsCreatedThenForcePinGemCloseWorkerAndValidateHostMemoryAreDisabled) {
2853-
DebugManagerStateRestore dbgStateRestore;
2854-
DebugManager.flags.EnableDirectSubmission.set(1u);
2855-
2856-
TestedDrmMemoryManager memoryManager(true, true, true, executionEnvironment);
2857-
2858-
EXPECT_FALSE(memoryManager.isValidateHostMemoryEnabled());
2859-
EXPECT_FALSE(memoryManager.forcePinEnabled);
2860-
}
2861-
28622852
TEST_F(DrmMemoryManagerBasic, givenEnabledAsyncDeleterFlagWhenMemoryManagerIsCreatedThenAsyncDeleterEnabledIsFalseAndDeleterIsNullptr) {
28632853
DebugManagerStateRestore dbgStateRestore;
28642854
DebugManager.flags.EnableDeferredDeleter.set(true);

shared/source/os_interface/linux/drm_memory_manager.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@ DrmMemoryManager::DrmMemoryManager(gemCloseWorkerMode mode,
3838
ExecutionEnvironment &executionEnvironment) : MemoryManager(executionEnvironment),
3939
forcePinEnabled(forcePinAllowed),
4040
validateHostPtrMemory(validateHostPtrMemory) {
41-
if (DebugManager.flags.EnableDirectSubmission.get() == 1) {
42-
this->forcePinEnabled = false;
43-
this->validateHostPtrMemory = false;
44-
}
45-
4641
for (uint32_t rootDeviceIndex = 0; rootDeviceIndex < gfxPartitions.size(); ++rootDeviceIndex) {
4742
auto gpuAddressSpace = executionEnvironment.rootDeviceEnvironments[rootDeviceIndex]->getHardwareInfo()->capabilityTable.gpuAddressSpace;
4843
getGfxPartition(rootDeviceIndex)->init(gpuAddressSpace, getSizeToReserve(), rootDeviceIndex, gfxPartitions.size(), heapAssigner.apiAllowExternalHeapForSshAndDsh);

shared/source/os_interface/linux/drm_memory_manager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class DrmMemoryManager : public MemoryManager {
106106
std::vector<void *> memoryForPinBBs;
107107
size_t pinThreshold = 8 * 1024 * 1024;
108108
bool forcePinEnabled = false;
109-
bool validateHostPtrMemory;
109+
const bool validateHostPtrMemory;
110110
std::unique_ptr<DrmGemCloseWorker> gemCloseWorker;
111111
decltype(&mmap) mmapFunction = mmap;
112112
decltype(&munmap) munmapFunction = munmap;

shared/test/unit_test/mocks/linux/mock_drm_memory_manager.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ class TestedDrmMemoryManager : public MemoryManagerCreate<DrmMemoryManager> {
5757
using DrmMemoryManager::createGraphicsAllocation;
5858
using DrmMemoryManager::createSharedBufferObject;
5959
using DrmMemoryManager::eraseSharedBufferObject;
60-
using DrmMemoryManager::forcePinEnabled;
6160
using DrmMemoryManager::getDefaultDrmContextId;
6261
using DrmMemoryManager::getDrm;
6362
using DrmMemoryManager::getRootDeviceIndex;

0 commit comments

Comments
 (0)