Remove unnecessary program of default value for allocation flags

kgibala · Compute-Runtime-Automation · commit dded0aa3bc28 · 2019-12-13T14:33:32.000+01:00
According to regression, remove setting value
for CL_MEM_ALLOC_DEFAULT_INTEL in MemoryPropertiesFlags

Related-To: NEO-4053
Change-Id: I1761bbf2ed8b977b7e96cebd38040c3977998b63
Signed-off-by: Krzysztof Gibala &lt;krzysztof.gibala@intel.com&gt;
diff --git a/core/memory_properties/memory_properties_flags_common.inl b/core/memory_properties/memory_properties_flags_common.inl
@@ -28,7 +28,6 @@ struct MemoryFlags {
 
 struct MemoryAllocFlags {
     uint32_t allocWriteCombined : 1;
-    uint32_t allocDefault : 1;
 };
 
 } // namespace NEO
diff --git a/runtime/helpers/memory_properties_flags_helpers_base.inl b/runtime/helpers/memory_properties_flags_helpers_base.inl
@@ -76,10 +76,6 @@ MemoryPropertiesFlags MemoryPropertiesFlagsParser::createMemoryPropertiesFlags(c
         memoryPropertiesFlags.allocFlags.allocWriteCombined = true;
     }
 
-    if (allocflags == CL_MEM_ALLOC_DEFAULT_INTEL) {
-        memoryPropertiesFlags.allocFlags.allocDefault = true;
-    }
-
     addExtraMemoryPropertiesFlags(memoryPropertiesFlags, flags, flagsIntel);
 
     return memoryPropertiesFlags;
diff --git a/unit_tests/helpers/memory_properties_flags_helpers_tests.cpp b/unit_tests/helpers/memory_properties_flags_helpers_tests.cpp
@@ -62,9 +62,6 @@ TEST(MemoryPropertiesFlags, givenValidPropertiesWhenCreateMemoryPropertiesFlagsT
 
     properties = MemoryPropertiesFlagsParser::createMemoryPropertiesFlags(0, 0, CL_MEM_ALLOC_WRITE_COMBINED_INTEL);
     EXPECT_TRUE(properties.allocFlags.allocWriteCombined);
-
-    properties = MemoryPropertiesFlagsParser::createMemoryPropertiesFlags(0, 0, CL_MEM_ALLOC_DEFAULT_INTEL);
-    EXPECT_TRUE(properties.allocFlags.allocDefault);
 }
 
 TEST(MemoryPropertiesFlags, givenClMemForceLinearStorageFlagWhenCreateMemoryPropertiesFlagsThenReturnProperValue) {

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,6 @@ MemoryPropertiesFlags MemoryPropertiesFlagsParser::createMemoryPropertiesFlags(c`
`76`	`76`	`memoryPropertiesFlags.allocFlags.allocWriteCombined = true;`
`77`	`77`	`}`
`78`	`78`
`79`		`- if (allocflags == CL_MEM_ALLOC_DEFAULT_INTEL) {`
`80`		`- memoryPropertiesFlags.allocFlags.allocDefault = true;`
`81`		`- }`
`82`		`-`
`83`	`79`	`addExtraMemoryPropertiesFlags(memoryPropertiesFlags, flags, flagsIntel);`
`84`	`80`
`85`	`81`	`return memoryPropertiesFlags;`
Original file line number	Diff line number	Diff line change
`@@ -62,9 +62,6 @@ TEST(MemoryPropertiesFlags, givenValidPropertiesWhenCreateMemoryPropertiesFlagsT`
`62`	`62`
`63`	`63`	`properties = MemoryPropertiesFlagsParser::createMemoryPropertiesFlags(0, 0, CL_MEM_ALLOC_WRITE_COMBINED_INTEL);`
`64`	`64`	`EXPECT_TRUE(properties.allocFlags.allocWriteCombined);`
`65`		`-`
`66`		`- properties = MemoryPropertiesFlagsParser::createMemoryPropertiesFlags(0, 0, CL_MEM_ALLOC_DEFAULT_INTEL);`
`67`		`- EXPECT_TRUE(properties.allocFlags.allocDefault);`
`68`	`65`	`}`
`69`	`66`
`70`	`67`	`TEST(MemoryPropertiesFlags, givenClMemForceLinearStorageFlagWhenCreateMemoryPropertiesFlagsThenReturnProperValue) {`